[SYCL] Record aspect names when computing device requirements #13974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeySachkov
approved these changes
May 31, 2024
| AspectValue = ExtractSignedIntegerFromMDNodeOperand(Pair, 1); | ||
| } else { | ||
| Val = mdconst::extract<ConstantInt>(MDOp)->getZExtValue(); | ||
| AspectValue = ExtractSignedIntegerFromMDNodeOperand(MDN, I); |
Contributor
There was a problem hiding this comment.
Just for my understanding: we could have a non-pair value in case of an internal aspect with a negative value and no name, right? Plus, it should serve as path for backwards compatibility if we link object files produced by an older toolchain, right?
Contributor
Author
There was a problem hiding this comment.
Yep, those are both correct.
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
…13974) After intel#13486, aspect name information is visible in `sycl-post-link` without the use of `!sycl_aspects`, so this PR updates `sycl-post-link` to use the aspect names that are now available within the `!sycl_used_aspects` metadata instead of `!sycl_aspects`. Aditionally, this PR also adds E2E related to optional kernel features for AOT enabled by these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #13486, aspect name information is visible in
sycl-post-linkwithout the use of!sycl_aspects, so this PR updatessycl-post-linkto use the aspect names that are now available within the!sycl_used_aspectsmetadata instead of!sycl_aspects.Aditionally, this PR also adds E2E related to optional kernel features for AOT enabled by these changes