-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][NFCI][ABI-Break] Move handler members to impl #14460
[SYCL][NFCI][ABI-Break] Move handler members to impl #14460
Commits on Jul 5, 2024
-
[SYCL][NFCI][ABI-Break] Move handler members to impl
This moves some of the members in the handler class to its impl class. Doing so allows developers to change these arguments without breaking ABI. This also moves more implementation details, such as command-group classes, launch configuration information, argument information and HostTask tracking, into sources to avoid hard-to-find ABI breaks in the communication between headers and runtime library. In addition to this, the following improvements are made: * The HostKernel class has been simplified to no longer have call and runOnHost functions. * The HostTask wrapper class has been moved to sources and the owner has been changed from a unique_ptr to a shared_ptr, which prevents the need for including host_task_impl.hpp in odd places. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 98c691c - Browse repository at this point
Copy the full SHA 98c691cView commit details -
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 5805367 - Browse repository at this point
Copy the full SHA 5805367View commit details
Commits on Jul 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8878682 - Browse repository at this point
Copy the full SHA 8878682View commit details -
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for e339faf - Browse repository at this point
Copy the full SHA e339fafView commit details -
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for d93ef7b - Browse repository at this point
Copy the full SHA d93ef7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fa05e8 - Browse repository at this point
Copy the full SHA 4fa05e8View commit details -
Fix AddLifetimeSharedPtrStorage arg
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 69abfe6 - Browse repository at this point
Copy the full SHA 69abfe6View commit details -
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for d1ca544 - Browse repository at this point
Copy the full SHA d1ca544View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2f49a5 - Browse repository at this point
Copy the full SHA a2f49a5View commit details -
Pad NDRDescT global size in NumWorkGroups case
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 5f99c91 - Browse repository at this point
Copy the full SHA 5f99c91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fdfcdd - Browse repository at this point
Copy the full SHA 8fdfcddView commit details -
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for ad2e20c - Browse repository at this point
Copy the full SHA ad2e20cView commit details
Commits on Jul 9, 2024
-
Fix formatting and missed padding case
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for c389dc0 - Browse repository at this point
Copy the full SHA c389dc0View commit details -
Move back to letting NDRDescT govern its padding
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 72f7fb6 - Browse repository at this point
Copy the full SHA 72f7fb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc76694 - Browse repository at this point
Copy the full SHA dc76694View commit details -
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for adf52d4 - Browse repository at this point
Copy the full SHA adf52d4View commit details -
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for e51e47a - Browse repository at this point
Copy the full SHA e51e47aView commit details -
Add back the case for interop_handle host_task
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 9b33cf5 - Browse repository at this point
Copy the full SHA 9b33cf5View commit details
Commits on Jul 10, 2024
-
Add interop handler include on hip and cuda tests
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 1d9e1f5 - Browse repository at this point
Copy the full SHA 1d9e1f5View commit details -
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for a0aba15 - Browse repository at this point
Copy the full SHA a0aba15View commit details
Commits on Jul 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 628ee06 - Browse repository at this point
Copy the full SHA 628ee06View commit details -
Add Windows symbols and change namings to match other members
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for abb11cc - Browse repository at this point
Copy the full SHA abb11ccView commit details -
Remove unreachable asserts causing Windows warnings
The group class cannot be used in host code, but one of its ctors uses asserts that only work on host. These assertions use % and / on ranges and MSVC thinks that these could potentially cause division by 0. Since these are unreachable they can be safely removed. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 1a4f3a3 - Browse repository at this point
Copy the full SHA 1a4f3a3View commit details
Commits on Jul 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for affd0ba - Browse repository at this point
Copy the full SHA affd0baView commit details