-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] kernel_compiler include file paths collision fix #14490
[SYCL] kernel_compiler include file paths collision fix #14490
Conversation
@@ -45,7 +52,7 @@ void ff_templated(T *ptr) { | |||
sycl::nd_item<1> Item = sycl::ext::oneapi::this_work_item::get_nd_item<1>(); | |||
|
|||
sycl::id<1> GId = Item.get_global_id(); | |||
ptr[GId.get(0)] = GId.get(0) + 39; | |||
ptr[GId.get(0)] = PlusEm(GId.get(0), 38); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 39
replaced with 38
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dm-vodopyanov ! There was a mistake in the test assertions and your question made me realize it existed. Fixed.
@dm-vodopyanov gentle ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kernel_compiler include_file support shouldn't have files that might collide. Spec has been recently clarified as well ( intel@a6d8758 )
kernel_compiler include_file support shouldn't have files that might collide. Spec has been recently clarified as well ( a6d8758 )