[SYCL][Bindless] Add interop memory mapping to USM. #14701

przemektmalon · 2024-07-23T09:11:30Z

This patch introduces map_external_linear_memory to enable mapping interop memory to linear USM, returning a void *.

The PI function piextMemMapExternalLinearMemory has been added to enable this in the PI layer.

A Vulkan test case has been added to test this functionality.

This patch introduces `map_external_linear_memory` to enable mapping interop memory to linear USM, returning a `void *`. The PI function `piextMemMapExternalLinearMemory` has been added to enable this in the PI layer. A Vulkan test case has been added to test this functionality.

przemektmalon · 2024-07-23T09:12:46Z

Associated UR PR

cperkinsintel · 2024-07-25T16:09:04Z

sycl/test-e2e/bindless_images/vulkan_interop/sampled_images_USM.cpp

+            size_t dim0 = it.get_global_id(0);
+            size_t dim1 = it.get_global_id(1);
+
+            // Normalize coordinates -- +0.5 to look towards centre of pixel


thanks for the comment!

przemektmalon · 2024-07-26T10:37:20Z

Friendly ping @intel/dpcpp-nativecpu-pi-reviewers

uwedolinsky

NativeCPU 👍

sycl/cmake/modules/FetchUnifiedRuntime.cmake

omarahmed1111 · 2024-07-31T14:28:32Z

Included PRs in this UR bump:

DBDuncan · 2024-08-02T12:04:55Z

@intel/llvm-gatekeepers Should be ok to merge? Does not touch HIP. Bindless images is not supported on AMD yet.

sommerlukas · 2024-08-02T12:12:32Z

Merging while HIP CI is stuck, as bindless images are not supported on HIP backend.

sarnex · 2024-08-02T14:14:34Z

@intel/bindless-images-reviewers Could this postcommit fail be related?

FAIL: SYCL-Unit :: program_manager/arg_mask/./ProgramManagerArgMaskTests/0/1 (1104 of 1159)
******************** TEST 'SYCL-Unit :: program_manager/arg_mask/./ProgramManagerArgMaskTests/0/1' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:/__w/llvm/llvm/build/tools/sycl/unittests/program_manager/arg_mask/./ProgramManagerArgMaskTests-SYCL-Unit-351801-0-1.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=1 GTEST_SHARD_INDEX=0 /__w/llvm/llvm/build/tools/sycl/unittests/program_manager/arg_mask/./ProgramManagerArgMaskTests
--

[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EliminatedArgMask
[ RUN      ] EliminatedArgMask.KernelBundleWith2Kernels
terminate called after throwing an instance of 'sycl::_V1::exception'
  what():  A local accessor must not be used in a SYCL kernel function that is invoked via single_task or via the simple form of parallel_for that takes a range parameter.
 #0 0x00007facd7034aa8 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/__w/llvm/llvm/build/./lib/libLLVMSupport.so.19.0git+0x182aa8)
 #1 0x00007facd703273c llvm::sys::RunSignalHandlers() (/__w/llvm/llvm/build/./lib/libLLVMSupport.so.19.0git+0x18073c)
 #2 0x00007facd7035158 SignalHandler(int) Signals.cpp:0:0
 #3 0x00007facd6990520 (/lib/x86_64-linux-gnu/libc.so.6+0x42520)
 #4 0x00007facd69e49fc pthread_kill (/lib/x86_64-linux-gnu/libc.so.6+0x969fc)
 #5 0x00007facd6990476 gsignal (/lib/x86_64-linux-gnu/libc.so.6+0x42476)
 #6 0x00007facd69767f3 abort (/lib/x86_64-linux-gnu/libc.so.6+0x287f3)
 #7 0x00007facd6d20b9e (/lib/x86_64-linux-gnu/libstdc++.so.6+0xa2b9e)
 #8 0x00007facd6d2c20c (/lib/x86_64-linux-gnu/libstdc++.so.6+0xae20c)
 #9 0x00007facd6d2c277 (/lib/x86_64-linux-gnu/libstdc++.so.6+0xae277)
#10 0x00007facd6d2c4d8 (/lib/x86_64-linux-gnu/libstdc++.so.6+0xae4d8)
#11 0x0000000000493baf getKernelArgMaskFromBundle(sycl::_V1::kernel_bundle<(sycl::_V1::bundle_state)0> const&, std::shared_ptr<sycl::_V1::detail::queue_impl>) (/__w/llvm/llvm/build/tools/sycl/unittests/program_manager/arg_mask/./ProgramManagerArgMaskTests+0x493baf)
#12 0x0000000000495689 EliminatedArgMask_KernelBundleWith2Kernels_Test::TestBody() (/__w/llvm/llvm/build/tools/sycl/unittests/program_manager/arg_mask/./ProgramManagerArgMaskTests+0x495689)
#13 0x00007facd7109160 testing::Test::Run() (/__w/llvm/llvm/build/./lib/libllvm_gtest.so.19.0git+0x3e160)
#14 0x00007facd710a5c9 testing::TestInfo::Run() (/__w/llvm/llvm/build/./lib/libllvm_gtest.so.19.0git+0x3f5c9)
#15 0x00007facd710b335 testing::TestSuite::Run() (/__w/llvm/llvm/build/./lib/libllvm_gtest.so.19.0git+0x40335)
#16 0x00007facd711c54d testing::internal::UnitTestImpl::RunAllTests() (/__w/llvm/llvm/build/./lib/libllvm_gtest.so.19.0git+0x5154d)
#17 0x00007facd711b889 testing::UnitTest::Run() (/__w/llvm/llvm/build/./lib/libllvm_gtest.so.19.0git+0x50889)
#18 0x00007facd730224c main (/__w/llvm/llvm/build/./lib/libllvm_gtest_main.so.19.0git+0x124c)
#19 0x00007facd6977d90 (/lib/x86_64-linux-gnu/libc.so.6+0x29d90)
#20 0x00007facd6977e40 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x29e40)
#21 0x000000000040a905 _start (/__w/llvm/llvm/build/tools/sycl/unittests/program_manager/arg_mask/./ProgramManagerArgMaskTests+0x40a905)

--
exit: -6
--
shard JSON output does not exist: /__w/llvm/llvm/build/tools/sycl/unittests/program_manager/arg_mask/./ProgramManagerArgMaskTests-SYCL-Unit-351801-0-1.json
********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
********************
Failed Tests (1):
  SYCL-Unit :: program_manager/arg_mask/./ProgramManagerArgMaskTests/0/1

DBDuncan · 2024-08-02T14:17:30Z

I can only imagine it maybe came from oneapi-src/unified-runtime#1880 ?

sarnex · 2024-08-02T14:20:13Z

@intel/unified-runtime-reviewers Can someone please assess the above postcommit fail and see if it could be related to the UR bump added in this PR? Thanks

aarongreig · 2024-08-02T16:14:50Z

@intel/unified-runtime-reviewers Can someone please assess the above postcommit fail and see if it could be related to the UR bump added in this PR? Thanks

we have reason to suspect that #14873 will fix this, if that merges and post-commit is still failing we will revert the bump and investigate further

sarnex · 2024-08-02T17:34:55Z

Seems build passes now, but there are some other postcommit failures. Will post in that PR. Thanks.

KornevNikita · 2024-08-05T11:30:57Z

@przemektmalon @sarnex this patch (UR TAG update) broke sycl-cts/test_event on linux L0: https://github.com/intel/llvm/actions/runs/10224788809/job/28293133692
This doesn't help - #14944

Do you know possible reasons?

sarnex · 2024-08-05T14:27:44Z

Adding @intel/bindless-images-reviewers (see above)

Can someone please investigate the CTS issue? If we can't fix it quickly probably we should revert this patch. Thanks

omarahmed1111 · 2024-08-05T14:34:24Z

@sarnex @KornevNikita I tried that locally and it comes from this PR: oneapi-src/unified-runtime#1880 . I will ping the team for that to see. if there is not a quick fix, will revert that and include the reverted PR in this bump: #14944

sarnex · 2024-08-05T14:36:19Z

Thanks Omar!

This patch introduces `map_external_linear_memory` to enable mapping interop memory to linear USM, returning a `void *`. The PI function `piextMemMapExternalLinearMemory` has been added to enable this in the PI layer. A Vulkan test case has been added to test this functionality. --------- Co-authored-by: Duncan Brawley <duncan.brawley@codeplay.com>

przemektmalon requested review from a team as code owners July 23, 2024 09:11

przemektmalon requested review from cperkinsintel and keyradical July 23, 2024 09:11

przemektmalon temporarily deployed to WindowsCILock July 23, 2024 09:11 — with GitHub Actions Inactive

przemektmalon mentioned this pull request Jul 23, 2024

[Bindless][Exp] Add interop memory mapping to USM. oneapi-src/unified-runtime#1882

Merged

przemektmalon temporarily deployed to WindowsCILock July 23, 2024 09:44 — with GitHub Actions Inactive

Seanst98 approved these changes Jul 24, 2024

View reviewed changes

keyradical approved these changes Jul 25, 2024

View reviewed changes

cperkinsintel reviewed Jul 25, 2024

View reviewed changes

cperkinsintel approved these changes Jul 25, 2024

View reviewed changes

DBDuncan approved these changes Jul 26, 2024

View reviewed changes

uwedolinsky approved these changes Jul 29, 2024

View reviewed changes

DBDuncan added 2 commits July 30, 2024 14:23

merge 'origin/sycl' into przemek/interop-map-memory

1535bb5

Update UR commit

7d695b7

DBDuncan had a problem deploying to WindowsCILock July 30, 2024 14:40 — with GitHub Actions Error

DBDuncan added 2 commits July 30, 2024 16:41

Update UR commit

e00f75d

Update sycl symbol tests

4de8771

DBDuncan temporarily deployed to WindowsCILock July 30, 2024 16:15 — with GitHub Actions Inactive

DBDuncan temporarily deployed to WindowsCILock July 30, 2024 18:41 — with GitHub Actions Inactive

Fix inconsitant naming

b9cff90

DBDuncan had a problem deploying to WindowsCILock July 31, 2024 10:07 — with GitHub Actions Error

Fix incorrect variable name

7cf39fb

DBDuncan had a problem deploying to WindowsCILock July 31, 2024 10:29 — with GitHub Actions Failure

omarahmed1111 reviewed Jul 31, 2024

View reviewed changes

sycl/cmake/modules/FetchUnifiedRuntime.cmake Outdated Show resolved Hide resolved

omarahmed1111 reviewed Jul 31, 2024

View reviewed changes

sycl/cmake/modules/FetchUnifiedRuntime.cmake Outdated Show resolved Hide resolved

Update UR commit

35f48c5

DBDuncan temporarily deployed to WindowsCILock July 31, 2024 14:21 — with GitHub Actions Inactive

pbalcer approved these changes Jul 31, 2024

View reviewed changes

DBDuncan had a problem deploying to WindowsCILock July 31, 2024 15:23 — with GitHub Actions Failure

DBDuncan temporarily deployed to WindowsCILock August 1, 2024 10:07 — with GitHub Actions Inactive

DBDuncan had a problem deploying to WindowsCILock August 1, 2024 10:07 — with GitHub Actions Failure

merge 'origin/sycl' into przemek/interop-map-memory

d2d24c1

DBDuncan temporarily deployed to WindowsCILock August 1, 2024 11:17 — with GitHub Actions Inactive

DBDuncan temporarily deployed to WindowsCILock August 1, 2024 11:49 — with GitHub Actions Inactive

sommerlukas merged commit 2321b3a into intel:sycl Aug 2, 2024

omarahmed1111 mentioned this pull request Aug 5, 2024

Revert "[L0] L0 impl for enqueue native command" oneapi-src/unified-runtime#1929

Merged

[SYCL][Bindless] Add interop memory mapping to USM. #14701

[SYCL][Bindless] Add interop memory mapping to USM. #14701

Uh oh!

Conversation

przemektmalon commented Jul 23, 2024

Uh oh!

przemektmalon commented Jul 23, 2024

Uh oh!

cperkinsintel Jul 25, 2024

Choose a reason for hiding this comment

Uh oh!

przemektmalon commented Jul 26, 2024

Uh oh!

uwedolinsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

omarahmed1111 commented Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DBDuncan commented Aug 2, 2024

Uh oh!

sommerlukas commented Aug 2, 2024

Uh oh!

sarnex commented Aug 2, 2024

Uh oh!

DBDuncan commented Aug 2, 2024

Uh oh!

sarnex commented Aug 2, 2024

Uh oh!

aarongreig commented Aug 2, 2024

Uh oh!

sarnex commented Aug 2, 2024

Uh oh!

KornevNikita commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sarnex commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omarahmed1111 commented Aug 5, 2024

Uh oh!

sarnex commented Aug 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

omarahmed1111 commented Jul 31, 2024 •

edited

Loading

KornevNikita commented Aug 5, 2024 •

edited

Loading

sarnex commented Aug 5, 2024 •

edited

Loading