[SYCL] Filter out the header and footer from the dependency output. #14933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahiraam
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zahiraam
changed the title
zahiraam
changed the title
zahiraam
changed the title
zahiraam
changed the title
zahiraam
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
approved these changes
Aug 5, 2024
mdtoguchi
reviewed
Aug 5, 2024
smanna12
approved these changes
Aug 5, 2024
|
@intel/llvm-gatekeepers This has high priority. Can it be merged please? Thanks. |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
…ntel#14933) `Cmake` uses dependency information generated by the use of the` -MD` option to decide if a file needs to be rebuilt. Currently the header and footer are not filtered out from the dependency output. This leads to the issue that `Cmake` thinks the source file needs to always be rebuilt. This is a patch to fix the issue. See intel#14798 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cmakeuses dependency information generated by the use of the-MDoption to decide if a file needs to be rebuilt. Currently the header and footer are not filtered out from the dependency output. This leads to the issue thatCmakethinks the source file needs to always be rebuilt.This is a patch to fix the issue.
See #14798 for more details.