Skip to content

[XPTI] Rename ur to ur.call in XPTI #14971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sommerlukas merged 1 commit into from
Aug 21, 2024
Merged

[XPTI] Rename ur to ur.call in XPTI #14971

sommerlukas merged 1 commit into from
Aug 21, 2024

Conversation

@RossBrunton
Copy link
Contributor

@RossBrunton RossBrunton commented Aug 6, 2024

Closes: #14922

@RossBrunton RossBrunton requested review from a team as code owners August 6, 2024 13:27
@RossBrunton
Copy link
Contributor Author

RossBrunton commented Aug 6, 2024

Requires UR changes from oneapi-src/unified-runtime#1940

@RossBrunton RossBrunton mentioned this pull request Aug 6, 2024
Merged
@RossBrunton RossBrunton force-pushed the ross/urcall branch 2 times, most recently from 069af2d to ec1a392 Compare August 13, 2024 11:18
@RossBrunton
Copy link
Contributor Author

RossBrunton commented Aug 13, 2024

Having a bit of trouble getting CI to behave, but I think the code here is correct and the UR change is approved.

Could someone from @intel/unified-runtime-reviewers and @intel/llvm-reviewers-runtime have a quick look at this and let me know if there's anything I need to change with the code?

@steffenlarsen
Copy link
Contributor

steffenlarsen commented Aug 14, 2024 •
edited
Loading

CI looks green to me! Just need a conflict resolution... And some reviews.

@omarahmed1111
Copy link
Contributor

omarahmed1111 commented Aug 20, 2024

@intel/llvm-gatekeepers Please merge, Thanks!

@sommerlukas sommerlukas merged commit 4c7d2f8 into intel:sycl Aug 21, 2024
@omarahmed1111
Copy link
Contributor

omarahmed1111 commented Aug 21, 2024

This PR bump includes PRs:

This was referenced Aug 21, 2024
Closed
Merged
Closed
Closed
Closed
Closed
AlexeySachkov pushed a commit to AlexeySachkov/llvm that referenced this pull request Nov 26, 2024
@RossBrunton @AlexeySachkov
[XPTI] Rename ur to ur.call in XPTI (intel#14971)
3887852 
Closes: intel#14922
@RossBrunton RossBrunton deleted the ross/urcall branch February 19, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov is a code owner automatically assigned from intel/llvm-reviewers-runtime

+1 more reviewer

@omarahmed1111 omarahmed1111 omarahmed1111 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rename UR xpti stream to ur.call

4 participants

@RossBrunton @steffenlarsen @omarahmed1111 @sommerlukas