Skip to content

Conversation

@fineg74
Copy link
Contributor

@fineg74 fineg74 commented Aug 23, 2024

No description provided.

@fineg74 fineg74 marked this pull request as ready for review August 23, 2024 03:08
@fineg74 fineg74 requested a review from a team as a code owner August 23, 2024 03:08
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a nit!

// REQUIRES: arch-intel_gpu_pvc
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
//==- spirv_fp_test.cpp - Test for abs function -==//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we put the REQUIRES/RUNS below the copyright header?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@sarnex
Copy link
Contributor

sarnex commented Aug 26, 2024

dev igc issue not related

@sarnex sarnex merged commit 894f40a into intel:sycl Aug 26, 2024
@fineg74 fineg74 deleted the absFix branch August 26, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants