[SYCL] Make SYCL_BE force selection of specified BE if there are multiple choices #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables including multiple devices of the same device_type and changed the logic of device selection to just prefer a SYCL_BE device if present. If someone uses SYCL_BE but appropriate device is not present, we will simply use any other device. Signed-off-by: Artur Gainullin <artur.gainullin@intel.com>
|
Please review only the second commit. This should be committed after #1490 |
…iple choices Signed-off-by: Artur Gainullin <artur.gainullin@intel.com>
againull
force-pushed
the
force_be_selection
branch
from
74b8417 to
d52dc7d
Compare
romanovvlad
reviewed
Apr 15, 2020
| @@ -60,6 +60,51 @@ vector_class<device> device::get_devices(info::device_type deviceType) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // If SYCL_BE is set and there are multiple devices of the same type | |||
There was a problem hiding this comment.
I'm confused with meaning of SYCL_BE var. In another PR you are making so that SYCL_BE makes some preference towards specified BE in the selectors, but this patch removes all devices that do not match specified BE.
The documentation says that this var controls which BE will be used when a device is chosen using default selector only.
I think we should have consistent behavior and update documentation. Probably we need to introduce new env var if we need two different behaviors(force and preference).
romanovvlad
requested changes
Apr 15, 2020
|
This was resolved in scope of #1490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.