-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Driver][SYCL] Use existing option for device-only and some cleanup #15274
Conversation
Update -fsycl-device-only usage to be an alias to --offload-device-only. This requires an additional unique check for SYCL enabling due to the expectation that -fsycl-device-only also implies -fsycl. Update associated tests that use -fsycl-device-only -emit-llvm. Our default is already bitcode output, fixing this up aligns better with community expectations when using --offload-device-only. Also do some variable cleanup to better be in sync with community variable names. And use a more common diagnostic for invalid options with -fsycl.
I find this behavior a bit confusing. My understanding is that by |
To support the ability to emit SPIR-V using the translator, we have |
Right. The primary reason for that is to support Relocatable Device Code ( My point is that community compiler uses We can also consider switching to |
@intel/llvm-gatekeepers, this should be ready for merge, thanks! |
…and some cleanup (intel#15274)" This partially reverts commit fd4b409, undoing the change to alias -fsycl-device-only and --offload-device-only but keeping the other cleanups, and adds a test showing why the alias does not work. Fixes intel#15319
Update -fsycl-device-only usage to be an alias to --offload-device-only. This requires an additional unique check for SYCL enabling due to the expectation that -fsycl-device-only also implies -fsycl.
Update associated tests that use -fsycl-device-only -emit-llvm. Our default is already bitcode output, fixing this up aligns better with community expectations when using --offload-device-only.
Also do some variable cleanup to better be in sync with community variable names. And use a more common diagnostic for invalid options with -fsycl.