[SYCL] Fix uncaught exception reported by analysis #15448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bso-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bso-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Sep 19, 2024
|
@intel/llvm-gatekeepers |
|
@bso-intel - Could you please add a description to this PR? If we merged this as-is it's very unclear for someone reading through the log what this PR fixed, except some uncaught exception somewhere. |
Hi @steffenlarsen , Done. |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 27, 2024
This PR fixes the uncuahgt exception in dllMain() reported by static analysis tool by adding a try-catch block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the uncuahgt exception in dllMain() reported by static analysis tool by adding a try-catch block.