Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate intel reqd sub group size #15798

Open
wants to merge 7 commits into
base: sycl
Choose a base branch
from
Open

Deprecate intel reqd sub group size #15798

wants to merge 7 commits into from
+233 −143

Conversation

dklochkov-emb
Copy link

  1. [[intel::reqd_sub_group_size]] was made deprecated. Warning will be raised when it is used
  2. Test to check warning was added into separate file (tests/warnings_deprecated.cpp) because tests/warnings.cpp contains flag to ignore deprecated warnings
  3. Test to check modern attribute - [[sycl::reqd_sub_group_size]] - was added to check that no one warning was raised
  4. Changes to use modern [[sycl::reqd_sub_group_size]] in tests were done
  5. Some of the tests named sub-group-size got compiler flag to ignore new warning

@dklochkov-emb dklochkov-emb requested review from a team as code owners October 22, 2024 08:58
AlexeySachkov
AlexeySachkov approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to sycl/test-e2e/AOT LGTM.

clang/lib/Sema/SemaSYCLDeclAttr.cpp Outdated Show resolved Hide resolved
clang/test/SemaSYCL/reqd-sub-group-size-ast.cpp Outdated Show resolved Hide resolved
clang/test/SemaSYCL/reqd-sub-group-size-host.cpp Outdated Show resolved Hide resolved
clang/test/SemaSYCL/reqd-sub-group-size.cpp Outdated Show resolved Hide resolved
clang/test/SemaSYCL/sycl-attr-warn-non-kernel.cpp Show resolved Hide resolved
sycl/test/warnings/warnings.cpp Outdated Show resolved Hide resolved
sycl/test/warnings/warnings_deprecated.cpp Outdated Show resolved Hide resolved
Alcpz
Alcpz approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Alcpz Alcpz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SYCLcompat tests changes LGTM

sarnex
sarnex approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esimd/tools lgtm

dkhaldi
dkhaldi approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JM changes LGTM

@AlexeySachkov AlexeySachkov mentioned this pull request Oct 23, 2024
Merged
elizabethandrews
elizabethandrews reviewed Oct 24, 2024
View reviewed changes
clang/lib/Sema/SemaDeclAttr.cpp
@@ -2859,6 +2859,25 @@ static void handleWorkGroupSize(Sema &S, Decl *D, const ParsedAttr &AL) {
WorkGroupAttr(S.Context, AL, WGSize[0], WGSize[1], WGSize[2]));
}

// Handles reqd_sub_group_size and sub_group_size.
static void handleSubGroupSize(Sema &S, Decl *D, const ParsedAttr &AL) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecation should not require the addition of a new handler here. Are the semantic checks expected to be different for for both spellings? If not I would just use the old handler and modify checkDeprecatedSYCLAttributeSpelling which I see you have already done.

clang/test/SemaSYCL/reqd-sub-group-size.cpp
@@ -32,20 +32,34 @@ int main() {
});
return 0;
}
// expected-note@+2 {{did you mean to use 'sycl::reqd_sub_group_size' instead?}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to replace all uses of deprecated spelling with new spelling instead of adding additional warning checks. Please keep/add one test with deprecated spelling to ensure warning is emitted.

clang/test/SemaSYCL/sub-group-size.cpp
@@ -10,20 +10,26 @@

#include "Inputs/sycl.hpp"

// expected-note@+4 {{did you mean to use 'sycl::reqd_sub_group_size' instead?}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments here.

clang/test/SemaSYCL/sycl-attr-warn-non-kernel.cpp
@@ -1,4 +1,4 @@
// RUN: %clang_cc1 -fsycl-is-device -internal-isystem %S/Inputs -fsyntax-only -verify -pedantic %s
// RUN: %clang_cc1 -fsycl-is-device -Wno-error=deprecated-declarations -internal-isystem %S/Inputs -fsyntax-only -verify -pedantic %s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this additional option was added when you do seem to be using the deprecated spelling in this test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizabethandrews elizabethandrews elizabethandrews left review comments

@Alcpz Alcpz Alcpz approved these changes

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@sarnex sarnex sarnex approved these changes

@dkhaldi dkhaldi dkhaldi approved these changes

@sergey-semenov sergey-semenov sergey-semenov approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dklochkov-emb @Alcpz @AlexeySachkov @sarnex @dkhaldi @sergey-semenov @elizabethandrews