[SYCL][COMPAT] Specialize reverse_bits for nvptx #15805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
JackAKirk
changed the title
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
changed the title
joeatodd
changed the title
joeatodd
requested changes
Oct 24, 2024
| @@ -161,6 +161,11 @@ inline double cast_ints_to_double(int high32, int low32) { | |||
| template <typename T> inline T reverse_bits(T a) { | |||
| static_assert(std::is_unsigned<T>::value && std::is_integral<T>::value, | |||
| "unsigned integer required"); | |||
| #if defined(__NVPTX__) | |||
There was a problem hiding this comment.
Could you if constexpr(std::is_same_v<T, unsigned> here? Theoretically this API accepts e.g. unsigned short, unsigned char and I guess the PTX wouldn't work for that.
Of course, the ptx for those cases could be defined too, so that'd be an alternative.
There was a problem hiding this comment.
Thanks for pointing this out. I've dealt with this using sizeof
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a ptx instruction to specialize
syclcompat::bit_reversefor NVPTX backend.