[CI] Only run one post commit job on a push to a pull request in sycl-devops-pr #16079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-devops-pr Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
| @@ -21,7 +21,7 @@ on: | |||
|
|
|||
| concurrency: | |||
| # Cancel a currently running workflow from the same PR or commit hash. | |||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }} | |||
| group: "${{ github.actor }}-${{ github.head_ref || github.ref_name }}" | |||
There was a problem hiding this comment.
I think PR's description needs to be copied/summarized here too.
There was a problem hiding this comment.
good point, added in latest commit
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
uditagarwal97
approved these changes
Nov 13, 2024
aelovikov-intel
approved these changes
Nov 13, 2024
|
Merging since postcommit passed in a previous run and this doesn't effect precommit and CI is really slammed, thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of a really specific case, but if someone pushes to
sycl-devops-prto run postcommit and then makes a PR from the same branch, both the initial pull request event and every subsequent push to the branch will cause two postcommits to run, one from the push to the branch and one from the PR.Use a unique key that will be the same in both cases so only one is run and the other is cancelled.
Nobody really uses this branch besides CI devs so we don't need to overengineer it so it never runs two in the first place IMO.