[clang][SYCL] Print canonical types in free function shim functions #16119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow even if the outer type was canonical, TypePrinter manages to skip nns printing in case of nested default template arguments. See added test case for the example.
Fznamznon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
lbushi25
approved these changes
Nov 19, 2024
elizabethandrews
approved these changes
Nov 19, 2024
Fznamznon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
|
@Fznamznon Is this good to merge? |
Contributor
Author
Yeah, @intel/llvm-gatekeepers please merge |
Contributor
Thank you for the quick resolution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow even if the outer type was canonical, TypePrinter manages to skip nns printing in case of nested default template arguments. See added test case for the example.