[SYCL] Improve SYCL library versioning macro #16137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a macro `__SYCL_COMPILER_VERSION` which only corresponds to a date when build was performed - it does not give any indication of the actual compiler version, nor does it give any indication of the actual library build. This patch attempts to deprecate that old macro and replaces it with `__LIBSYCL_TIMESTAMP` which contains a date of the latest commit included into the SYCL library (and therefore SYCL headers) build. Using commit date is more relibable than build date and its naming speicifally refers to library instead of the compiler. "Attempts" above is because it is a bit tricky to deprecate a macro and heavily depends on the compiler which is being used. Not every 3rd-party host compiler is covered, i.e. deprecation message may only be emitted from device compilation pass in certain cases. Resolves intel#2250
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bader
reviewed
Nov 25, 2024
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bader
approved these changes
Nov 29, 2024
|
|
||
| #ifndef __LIBSYCL_TIMESTAMP | ||
| #error "__LIBSYCL_TIMESTAMP is expected to be defined by sycl.hpp" | ||
| Some weird code to cause compilation error |
There was a problem hiding this comment.
Do we need this line? I expect #error preprocessor directive to emit an error.
| # the hash won't be updated. It is not considered to be a problem, because for | ||
| # local incremental builds made during the library/headers development the date | ||
| # doesn't matter much and we can guarantee it to be always correct when we do | ||
| # nightly builds. |
There was a problem hiding this comment.
It sounds like you assume that nightly builds != incremental builds. I don't think we have a formal requirement for our CI system like this. Perhaps we can explicitly state that here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a macro
__SYCL_COMPILER_VERSIONwhich only corresponds to a date when build was performed - it does not give any indication of the actual compiler version, nor does it give any indication of the actual library build.This patch attempts to deprecate that old macro and replaces it with
__LIBSYCL_TIMESTAMPwhich contains a date of the latest commit included into the SYCL library (and therefore SYCL headers) build. Using commit date is more relibable than build date and its naming speicifally refers to library instead of the compiler."Attempts" above is because it is a bit tricky to deprecate a macro and heavily depends on the compiler which is being used. Not every 3rd-party host compiler is covered, i.e. deprecation message may only be emitted from device compilation pass in certain cases.
Resolves #2250