[SYCL] Fix several errors in accessor #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
reviewed
May 24, 2019
This patch fixes 2 constructors, fixes get_count() and get_size() methods, adds operator== and operator!=, fixes hash implementation, adds static_asssert to range and id classes to have early check for wrong dimension, fixes few other errors. Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
v-klochkov
force-pushed
the
public_acc20_fixes
branch
from
e7ca387 to
14b635a
Compare
bader
approved these changes
May 26, 2019
Contributor
bader
left a comment
bader
left a comment
There was a problem hiding this comment.
Thanks!
Very good improvement.
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Jan 18, 2021
CONFLICT (content): Merge conflict in clang/lib/Frontend/CompilerInvocation.cpp CONFLICT (content): Merge conflict in clang/include/clang/Driver/Options.td
coldav
pushed a commit
to coldav/llvm
that referenced
this pull request
Aug 22, 2025
[vecz] Don't mask work-group collective operations
coldav
pushed a commit
to coldav/llvm
that referenced
this pull request
Aug 26, 2025
[vecz] Don't mask work-group collective operations
coldav
pushed a commit
to coldav/llvm
that referenced
this pull request
Aug 29, 2025
[vecz] Don't mask work-group collective operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes 2 constructors, fixes get_count() and get_size() methods,
adds operator== and operator!=, fixes hash implementation,
adds static_asssert to range and id classes to have early check for wrong
dimension, fixes few other errors.
Signed-off-by: Vyacheslav N Klochkov vyacheslav.n.klochkov@intel.com