[SYCL] Update compiler design doc to reflect changed action graphs. #1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvchupin
reviewed
May 1, 2020
mdtoguchi
reviewed
May 1, 2020
Contributor
Author
|
@pvchupin , thanks, will apply. Accidentally overwritten the branch - will restore. |
kbobrovs
commented
May 2, 2020
alexbatashev
reviewed
May 2, 2020
AGindinson
reviewed
May 3, 2020
kbobrovs
commented
May 5, 2020
kbobrovs
commented
May 5, 2020
kbobrovs
commented
May 5, 2020
- Correct the high-level application build diagram. - Describe the new file-table-tform tool usage. - Describe clang action graphs used in various SYCL compilation scenarios in more details. Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com> Co-authored-by: Pavel Chupin <45979248+pvchupin@users.noreply.github.com> Co-authored-by: mdtoguchi <47896532+mdtoguchi@users.noreply.github.com> Co-authored-by: Artem Gindinson <artem.gindinson@intel.com>
pvchupin
previously approved these changes
May 5, 2020
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
Fznamznon
reviewed
May 6, 2020
Co-authored-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
Co-authored-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
Co-authored-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
Co-authored-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
Co-authored-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
Contributor
Author
|
@pvchupin, would mind approving once again and merging please? |
Fznamznon
previously approved these changes
May 7, 2020
pvchupin
reviewed
May 7, 2020
Co-authored-by: Pavel Chupin <45979248+pvchupin@users.noreply.github.com>
pvchupin
approved these changes
May 8, 2020
dbudanov-cmplr
pushed a commit
to dbudanov-cmplr/llvm
that referenced
this pull request
Sep 28, 2022
With this commit, the last call to Type::getPointerElementType in the translator is truly dead, completing the first phase of transitioning to opaque pointers. Original commit: KhronosGroup/SPIRV-LLVM-Translator@3938c74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scenarios in more details.
Signed-off-by: Konstantin S Bobrovsky konstantin.s.bobrovsky@intel.com