Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][ESIMD][E2E] Fix printf's format specifier in dgetrf_8x8.cpp #16541

Merged
merged 3 commits into from
Jan 7, 2025
Merged

[SYCL][ESIMD][E2E] Fix printf's format specifier in dgetrf_8x8.cpp #16541

merged 3 commits into from
Jan 7, 2025

Conversation

uditagarwal97
Copy link
Contributor

Fixes: CMPLRTST-26008

@uditagarwal97 uditagarwal97 self-assigned this Jan 7, 2025
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner January 7, 2025 16:40
@uditagarwal97 uditagarwal97 requested a review from sarnex January 7, 2025 16:40
@uditagarwal97 uditagarwal97 changed the title [ESIMD] Fixe printf's format specifier in dgetrf_8x8.cpp [ESIMD] Fix printf's format specifier in dgetrf_8x8.cpp Jan 7, 2025
sarnex
sarnex approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please use the following prefix for the PR
[SYCL][ESIMD][E2E]

thx

@uditagarwal97 uditagarwal97 changed the title [ESIMD] Fix printf's format specifier in dgetrf_8x8.cpp [SYCL][ESIMD][E2E] Fix printf's format specifier in dgetrf_8x8.cpp Jan 7, 2025
@uditagarwal97 uditagarwal97 requested a review from sarnex January 7, 2025 19:18
@uditagarwal97
Copy link
Contributor Author

@sarnex I ended up using PRId64 as int64_t can either be long (in CI) or long long (see JIRA). I suppose PRId64 would be more portable.

@uditagarwal97
Copy link
Contributor Author

@intel/llvm-gatekeepers The PR is ready to be merged. Gen12 failure is unrelated and already reported in #16514

@sarnex sarnex merged commit 01a909a into sycl Jan 7, 2025
16 of 17 checks passed
@uditagarwal97 uditagarwal97 deleted the uditagarwal97-esimd-test-fix branch January 7, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnex sarnex sarnex approved these changes

Assignees

@uditagarwal97 uditagarwal97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uditagarwal97 @sarnex