Skip to content

[SYCL] Add E2E test for -foffload-fp32-prec-div/sqrt #17037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarnex merged 7 commits into from
Feb 25, 2025
Merged

[SYCL] Add E2E test for -foffload-fp32-prec-div/sqrt #17037

sarnex merged 7 commits into from
Feb 25, 2025

Conversation

@MrSidims
Copy link
Contributor

@MrSidims MrSidims commented Feb 17, 2025 •
edited
Loading

Supporting doc: #17033

@MrSidims
[SYCL] Add E2E test for -foffload-fp32-prec-div/sqrt
4a5678f 
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
@MrSidims
remove sycl.hpp
65049e6 
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
@MrSidims MrSidims marked this pull request as ready for review February 17, 2025 15:34
@MrSidims MrSidims requested a review from a team as a code owner February 17, 2025 15:34
@MrSidims
Copy link
Contributor Author

MrSidims commented Feb 18, 2025

@intel/llvm-reviewers-runtime please take a look

aelovikov-intel
aelovikov-intel reviewed Feb 18, 2025
View reviewed changes
@MrSidims
simplify
20068a6 
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
@MrSidims
Copy link
Contributor Author

MrSidims commented Feb 19, 2025

CUDA results:
Failed Tests (1):
SYCL :: DeviceLib/built-ins/offload-prec-div-sqrt.cpp

guess I first need this patch to be merged #17044

aelovikov-intel
aelovikov-intel reviewed Feb 19, 2025
View reviewed changes
aelovikov-intel
aelovikov-intel reviewed Feb 19, 2025
View reviewed changes
cperkinsintel
cperkinsintel reviewed Feb 19, 2025
View reviewed changes
@MrSidims
apply suggestions
8cd6672 
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
@MrSidims
std->sycl
7761947 
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
@MrSidims
Copy link
Contributor Author

MrSidims commented Feb 20, 2025

HIP and BMG failures are unrelated

aelovikov-intel
aelovikov-intel approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't like the naming of the helper. IMO, just inlining == would be better, but I can live with the current version.

@MrSidims
apply suggestion
d5b8823 
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
@MrSidims
Copy link
Contributor Author

MrSidims commented Feb 20, 2025 •
edited
Loading

I still don't like the naming of the helper. IMO, just inlining == would be better, but I can live with the current version.

Well, inlining into the assert imho looks quite unpleasant (at least in my IDE), but I can get rid of the function without any regret.

@MrSidims MrSidims requested a review from a team February 25, 2025 20:34
@MrSidims
Copy link
Contributor Author

MrSidims commented Feb 25, 2025

@intel/llvm-gatekeepers please help with the merge

@sarnex sarnex merged commit 9164df1 into intel:sycl Feb 25, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MrSidims @cperkinsintel @aelovikov-intel @sarnex