[SYCL] [UR] Add command buffer operations tests #17159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xewar313
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
reviewed
Feb 25, 2025
unified-runtime/test/conformance/exp_command_buffer/rect_read.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/test/conformance/exp_command_buffer/rect_read.cpp
Outdated
Show resolved
Hide resolved
Xewar313
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Xewar313
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Xewar313
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Xewar313
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Xewar313
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Xewar313
force-pushed
the
add-unified-runtime-tests
branch
from
cb60659 to
2f0cd00
Compare
Xewar313
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Xewar313
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
approved these changes
Mar 31, 2025
| testParametersMemcpy>::TearDown()); | ||
| } | ||
|
|
||
| void verifyData(std::vector<uint8_t> &output, std::vector<uint8_t> &input) { |
There was a problem hiding this comment.
could make these params const too, same in other new tests
pbalcer
reviewed
Mar 31, 2025
| @@ -908,16 +908,9 @@ ur_result_t ur_queue_immediate_in_order_t::enqueueGenericCommandListsExp( | |||
|
|
|||
| auto [pWaitEvents, numWaitEvents] = | |||
| getWaitListView(commandListLocked, phEventWaitList, numEventsInWaitList); | |||
| // zeCommandListImmediateAppendCommandListsExp is not working with in-order | |||
There was a problem hiding this comment.
I think for now we might need a check "if driver version is older than add sync", because CI won't have a new enough version yet.
Xewar313
force-pushed
the
add-unified-runtime-tests
branch
from
7223e2e to
0f3fbd4
Compare
pbalcer
approved these changes
May 5, 2025
|
@intel/llvm-gatekeepers please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some tests that check most basic command buffer functionalities