Skip to content

[UR][L0] Disable Immediate Command List DG2 Windows #17334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarnex merged 2 commits into from
Mar 7, 2025
Merged

[UR][L0] Disable Immediate Command List DG2 Windows #17334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afbe811
[UR][L0] Disable Immediate Command List DG2 Windows
nrspruit Mar 6, 2025
a8f5768
Add check that allows immediate command lists on non DG2 by default
nrspruit Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion unified-runtime/source/adapters/level_zero/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1512,12 +1512,23 @@ ur_device_handle_t_::useImmediateCommandLists() {
bool isDG2OrNewer = this->isIntelDG2OrNewer();
bool isDG2SupportedDriver =
this->Platform->isDriverVersionNewerOrSimilar(1, 5, 30820);
if ((isDG2SupportedDriver && isDG2OrNewer) || isPVC()) {
// Disable immediate command lists for DG2 devices on Windows due to driver
// limitations.
bool isLinux = true;
#ifdef _WIN32
isLinux = false;
#endif
if ((isDG2SupportedDriver && isDG2OrNewer && isLinux) || isPVC() ||
isNewerThanIntelDG2()) {
return PerQueue;
} else {
return NotUsed;
}
}

logger::info("NOTE: L0 Immediate CommandList Setting: {}",
ImmediateCommandlistsSetting);

switch (ImmediateCommandlistsSetting) {
case 0:
return NotUsed;
Expand Down
5 changes: 5 additions & 0 deletions unified-runtime/source/adapters/level_zero/device.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,11 @@ struct ur_device_handle_t_ : _ur_object {
ZeDeviceIpVersionExt->ipVersion >= 0x030dc000);
}

bool isNewerThanIntelDG2() {
return (ZeDeviceProperties->vendorId == 0x8086 &&
ZeDeviceIpVersionExt->ipVersion >= 0x030f0000);
}

bool isIntegrated() {
return (ZeDeviceProperties->flags & ZE_DEVICE_PROPERTY_FLAG_INTEGRATED);
}
Expand Down