Skip to content

[UR][L0] Release parent of sub-buffer when sub-buffer dies #17489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2025
Merged

[UR][L0] Release parent of sub-buffer when sub-buffer dies #17489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a4c29f
[UR][L0] Release parent of sub-buffer when sub-buffer dies
steffenlarsen Mar 17, 2025
1407747
Merge remote-tracking branch 'intel/sycl' into steffen/release_parent_l0
steffenlarsen Mar 24, 2025
ac348a6
Merge remote-tracking branch 'intel/sycl' into steffen/release_parent_l0
steffenlarsen Mar 24, 2025
b463947
Merge remote-tracking branch 'intel/sycl' into steffen/release_parent_l0
steffenlarsen Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions unified-runtime/source/adapters/level_zero/memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2341,6 +2341,11 @@ _ur_buffer::_ur_buffer(ur_context_handle_t Context, size_t Size,
LastDeviceWithValidAllocation = Device;
}

_ur_buffer::~_ur_buffer() {
if (isSubBuffer())
ur::level_zero::urMemRelease(SubBuffer->Parent);
}

ur_result_t ur_mem_handle_t_::getZeHandle(char *&ZeHandle, access_mode_t mode,
ur_device_handle_t Device,
const ur_event_handle_t *phWaitEvents,
Expand Down
2 changes: 2 additions & 0 deletions unified-runtime/source/adapters/level_zero/memory.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ struct _ur_buffer final : ur_mem_handle_t_ {
_ur_buffer(ur_context_handle_t Context, size_t Size,
ur_device_handle_t Device, char *ZeMemHandle, bool OwnZeMemHandle);

~_ur_buffer();

// Returns a pointer to the USM allocation representing this PI buffer
// on the specified Device. If Device is nullptr then the returned
// USM allocation is on the device where this buffer was used the latest.
Expand Down