[SYCL] Fix one more warning coming from SYCL headers #1758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com>
Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com>
Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com>
bader
reviewed
May 26, 2020
Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com>
s-kanaev
reviewed
May 26, 2020
| myQueue.submit([&](handler& cgh) { | ||
| auto writeResult = resultBuf.get_access<access::mode::write>(cgh); | ||
| cgh.single_task<class kernel_name>([=]() { | ||
| writeResult[0] = (vec<int, 4>{1, 2, 3, 4}).template convert<long>(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Are there any cases that were covered with old test and not covered by the new test?
There was a problem hiding this comment.
I think no, there was just a simple program that launches the check of warnings.
There was a problem hiding this comment.
But maybe we should ask the code owner.
Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com>
|
@turinevgeny, approve, please, if no objections. |
bb-sycl
pushed a commit
that referenced
this pull request
Jan 18, 2023
…fo (#1758) Also allow binary float spec constant input by passing a hex value with 0x prefix. Original commit: KhronosGroup/SPIRV-LLVM-Translator@b0c2bb1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed "warning: '&&' within '||' [-Wlogical-op-parentheses]" in types.hpp: it wasn't caught by the originally added test, because it is triggered only if corresponding template is instantiated.
Adjusted clang arguments in existing test for warnings as follow-up on #1583
Signed-off-by: Aleksander Fadeev aleksander.fadeev@intel.com