[SYCL] Fix 1-element vec ambiguities
#17722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will be updated as I upload PRs to implement recent specification changes.
Implements KhronosGroup/SYCL-Docs#668. Note that the "test" added here is less of a documentation of "intent" but rather the documentation of the effect of the change. Also, the idea behind specification changes was to keep all "reasonable" code in the wild compiling and several changes are needed together to make that happen. Until all of them land, keep the new code out of `-fpreview-breaking-changes` mode.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KhronosGroup/SYCL-Docs#670 Technically, we also implement part of KhronosGroup/SYCL-Docs#674 (`std::byte` as element type) here, but there is no reasonable way to make them completely independent. This is built on top of intel#17712 and intel#17713. With these three pieces in place we can keep building CTS successfully, so enable this new implementation (via `__SYCL_USE_PREVIEW_VEC_IMPL`) automatically under `-fpreview-breaking-changes` mode.
aelovikov-intel
force-pushed
the
one-elem-vec
branch
from
f50e938 to
b7edbc3
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Apr 1, 2025
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
I decided not to enable this by default in preview mode just yet. @cperkinsintel , do you mind taking one more look? |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Apr 2, 2025
ggojska
pushed a commit
to ggojska/llvm
that referenced
this pull request
Apr 7, 2025
Implements KhronosGroup/SYCL-Docs#670. Technically, we also implement part of KhronosGroup/SYCL-Docs#674 (`std::byte` as element type) here, but there is no reasonable way to make them completely independent. This is built on top of intel#17712 and intel#17713.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements KhronosGroup/SYCL-Docs#670.
Technically, we also implement part of KhronosGroup/SYCL-Docs#674
(
std::byteas element type) here, but there is no reasonable wayto make them completely independent.
This is built on top of #17712 and #17713.