[SYCL] Stabilize linux pre-commit on 6.1 release branch #17795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes the `build-and-run-mode` feature from e2e lit infrastructure,
as well as the remaining `REQUIRES: build-and-run-mode` markups found in
tests.
- Removes the `run-only` mode ignore line filtering workaround on
`REQUIRES: build-and-run-mode`.
- Adds `build-mode` to remove `test-mode-run-only` mode, this can be
tested for by checking `run-mode && !build-mode`.
- Marks CPU aot compilation lines with `%{run-aux}`, as those need to be
compiled on a system with the same CPU isa as the running system.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a joined cherry-pick of #16217, #16865 and #17023 intended to port necessary test tweaks to fix infrastructure-related pre-commit issues on
sycl-rel_6_1_0branch.Descriptions of cherry-picked commits:
[SYCL][E2E] Change pattern matching to if-else statements in
lit.cfg.py(#16217)Fixes #16211
Patch-By: David Garcia Orozco david.garcia.orozco@intel.com
[SYCL][E2E] Hack
AddressSanitizer/.../device_global.cppto pass CI (#16865)Closes #16850.
Patch-By: aelovikov-intel andrei.elovikov@intel.com
[SYCL][E2E] Clean-up
test-modes by removing workarounds (#17023)build-and-run-modefeature from e2e lit infrastructure,as well as the remaining
REQUIRES: build-and-run-modemarkups found intests.
run-onlymode ignore line filtering workaround onREQUIRES: build-and-run-mode.build-modeto removetest-mode-run-onlymode, this can betested for by checking
run-mode && !build-mode.%{run-aux}, as those need to becompiled on a system with the same CPU isa as the running system.
Patch-By: David Garcia Orozco david.garcia.orozco@intel.com