[SYCL] Re-implement swizzles from scratch #17817
Conversation
aelovikov-intel
commented
Apr 2, 2025
aelovikov-intel
commented
- Removes expression trees support
- Applies all previous vec fixes to align with recent spec changes
* Removes expression trees support * Applies all previous vec fixes to align with [proposed] spec changes
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -477,6 +500,172 @@ template <typename Self> struct VecOperators { | |||
| OpAssign<ShiftRight>, IncDec> {}; | |||
| }; | |||
|
|
|||
| #if !__SYCL_USE_LIBSYCL8_VEC_IMPL | |||
| template <typename Self> struct SwizzleOperators { | |||
There was a problem hiding this comment.
Nit; The Self name is used all around to represent a shared-pointer to the implementation itself. Could we maybe call this SelfT to disambiguate?
There was a problem hiding this comment.
I think it's a bit late: https://github.com/search?q=repo%3Aintel%2Fllvm+Self+path%3Asycl%2Finclude%2Fsycl%2F&type=code. I also don't see an issue with that. IMO, Self is like this but just a bit different. shared-pointer impl or CRTP both satisfy that view.
There was a problem hiding this comment.
IMO, Self is like this but just a bit different. shared-pointer impl or CRTP both satisfy that view.
That's my point. The shared-pointer impl is like this but different, and I don't see a reflective type being as close. Even if you could make the argument that it is, it creates the ambiguity that I wanted to avoid. Alas, it's just a nit, so I won't fight. 😉
It is breaking, we'll only do that under preview (once I merge all the changes to reflect spec modifications). @gmlueck was owning that item to get approvals. One request from up high was to preserve some way to get back old implementation even in the next major release (hence |
At this point, all of the SYCL 2020 specification changes for |
