-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Matching sizeof long double of SYCL device with that of host #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Matching sizeof long double of SYCL device with that of host #1786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK community does such things in a bit other way. See 8557d1a .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fznamznon : That one is interesting! I wonder if we should just do that for SYCL as well (modify that 'if' statement). I think this one is 'the right' way, but if community has already made that selection perhaps we need to as well.
Additionally, I think that method actually correctly handles the double-size flags, which this doesn't seem to do.
I think we should be aligned with community code and generalize approaches between SYCL and other offloading models which already is presented in master (like OpenMP), because they solve similar problems quite often. One problem I know with this community method - it crashes if user didn't specify AUX triple, but It is easy to fix by adding check on AUX triple presence. |
801ca3b
to
5ccac4c
Compare
static_assert of sizeof(long double)>8 fails to compile with -fsycl switch on Linux x86_64 bit target because sizeof(long double) for SYCL device is 8 bytes whereas the host is 16 bytes. This commit sets sizeof(long double) of SYCL device to match that of host
5ccac4c
to
d89721c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please stop force pushing. I've sent you an email on how to fix this.
static_assert of sizeof(long double)>8 fails to compile with -fsycl
switch because sizeof(long double) for SYCL device is 8 bytes whereas
the host is 16 bytes. This commit sets sizeof(long double) width to 16
bytes to match that of SYCL host for Linux gnu SYCLdevice x86_64 and x86