[UR][CL] Use regular malloc where clHostMemAllocINTEL_fn is not supported for USM allocs. #18119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
reviewed
Apr 23, 2025
aarongreig
reviewed
Apr 23, 2025
martygrant
force-pushed
the
martin/openclUSMAlloc
branch
from
3649429 to
3dea336
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
reviewed
Apr 25, 2025
aarongreig
reviewed
Apr 25, 2025
aarongreig
reviewed
Apr 25, 2025
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
martygrant
force-pushed
the
martin/openclUSMAlloc
branch
from
0f09aef to
b8bc61a
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kbenzie
changed the title
Contributor
Author
|
Failing test for |
aarongreig
reviewed
Apr 28, 2025
aarongreig
reviewed
Apr 28, 2025
…callback structs in usm.hpp with a base class and derived classes for USM and non-USM free calls.
…leterCallbackInfoIntel to AllocDeleterCallbackInfoUSM. Correct AllocDeleterCallback type.
martygrant
force-pushed
the
martin/openclUSMAlloc
branch
from
b8bc61a to
69d72e3
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
…ckInfoBase destructor into class definition.
martygrant
force-pushed
the
martin/openclUSMAlloc
branch
from
69d72e3 to
e9416b7
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
approved these changes
Apr 28, 2025
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes oneapi-src/unified-runtime#1837
The UR OpenCL adapter expects patterns of 2 for USM allocs, and fallsback to using clHostMemAllocINTEL_fn for non patterns of 2. Some devices/platforms don't support this extension so we can just use a regular malloc instead.