Skip to content

[SYCL] Use inline in device definition of _invalid_parameter #18451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from

Conversation

ianayl
Copy link
Contributor

@ianayl ianayl commented May 13, 2025

Header definitions should be inline to avoid multiple definitions error.

@ianayl ianayl requested a review from a team as a code owner May 13, 2025 19:09
@ianayl ianayl requested a review from cperkinsintel May 13, 2025 19:09
@ianayl ianayl temporarily deployed to WindowsCILock May 13, 2025 19:09 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 13, 2025 19:36 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 14, 2025 16:58 — with GitHub Actions Inactive
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this version doesn't help with the error downstream... Ian, can you confirm it's fixed?

@ianayl
Copy link
Contributor Author

ianayl commented May 14, 2025

@aelovikov-intel This was the version that fixed the downstream kmeans build failures, I later realized me not being able to replicate was because of my environment.

I am testing to see if this'll also fix post commit: https://github.com/intel/llvm/actions/runs/15026620724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants