[SYCL] Increase test coverage for root group extension #18745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
againull
approved these changes
Jun 3, 2025
Contributor
|
@0x12CC This PR has caused post-commit failures: https://github.com/intel/llvm/actions/runs/15427334189 Could you please a take a look? |
againull
added a commit
to againull/llvm
that referenced
this pull request
Jun 3, 2025
Contributor
Fixed in #18797 |
againull
added a commit
that referenced
this pull request
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain branches in functions related to the root group extension's work item query were not covered by any tests. This change removes a subset of them (conditionally, using the
__INTEL_PREVIEW_BREAKING_CHANGESmacro, to maintain the ABI) and adds tests for the others.