[UR][SYCL] Introduce UR api to set kernel args + launch in one call. #18764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
igchor
reviewed
Jun 2, 2025
unified-runtime/source/adapters/level_zero/v2/queue_immediate_in_order.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/queue_immediate_in_order.cpp
Outdated
Show resolved
Hide resolved
aarongreig
force-pushed
the
aaron/enqueueKernelWithArgs
branch
from
b91b20e to
76612c5
Compare
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
pbalcer
reviewed
Jun 3, 2025
aarongreig
force-pushed
the
aaron/enqueueKernelWithArgs
branch
from
76612c5 to
1554457
Compare
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
force-pushed
the
aaron/enqueueKernelWithArgs
branch
from
7a2f91c to
6123fa6
Compare
aarongreig
force-pushed
the
aaron/enqueueKernelWithArgs
branch
from
6123fa6 to
cebad02
Compare
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
reviewed
Jul 24, 2025
againull
approved these changes
Jul 25, 2025
|
CI fails are unrelated, same set seen in another PR here https://github.com/intel/llvm/actions/runs/16532939566/job/46762455916 |
maarquitos14
approved these changes
Jul 28, 2025
|
@intel/llvm-gatekeepers fails are unrelated and there's a change open to disable to tests in question #19606 I think this is ready to merge |
|
Happy to merge, but please add a description first |
done |
github-actions bot
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
Aug 5, 2025
…e call." (#19661) Reverts intel/llvm#18764 Looks like the naive level zero implementation now results in a performance regression, I think it's best to revert until l0 can better match the new interface.
aarongreig
added a commit
to oneapi-src/unified-runtime
that referenced
this pull request
Aug 5, 2025
…e call." (#19661) Reverts intel/llvm#18764 Looks like the naive level zero implementation now results in a performance regression, I think it's best to revert until l0 can better match the new interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
urEnqueueKernelLaunchWithArgsExp, a new UR entry point which allows combiningKernelSetArgandEnqueueKernelLaunchcalls into one. ReplacesurEnqueueKernelLaunchas the default kernel launch path in sycl RT.