Skip to content

[SYCL][Devicelib] Implement cmath rintf wrapper with __spirv_ocl_rint #18857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
againull merged 3 commits into from
Jun 10, 2025
Merged

[SYCL][Devicelib] Implement cmath rintf wrapper with __spirv_ocl_rint #18857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1a00d8
[SYCL][Devicelib] Add __devicelib_rint and fallback to __spirv_ocl_rint
wenju-he Jun 9, 2025
b7b3385
add test, remove fallback
wenju-he Jun 10, 2025
f340020
remove sycl test, rint is lowered to llvm.rint.f32 intrinsic for spir…
wenju-he Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions libdevice/cmath_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,16 +198,17 @@ float nearbyintf(float x) { return __nv_nearbyintf(x); }
extern "C" SYCL_EXTERNAL float __nv_rintf(float);
DEVICE_EXTERN_C_INLINE
float rintf(float x) { return __nv_rintf(x); }
#endif // __NVPTX__

#ifdef __AMDGCN__
#elif defined(__AMDGCN__)
extern "C" SYCL_EXTERNAL float __ocml_nearbyint_f32(float);
DEVICE_EXTERN_C_INLINE
float nearbyintf(float x) { return __ocml_nearbyint_f32(x); }

extern "C" SYCL_EXTERNAL float __ocml_rint_f32(float);
DEVICE_EXTERN_C_INLINE
float rintf(float x) { return __ocml_rint_f32(x); }
#endif // __AMDGCN__
#else
DEVICE_EXTERN_C_INLINE
float rintf(float x) { return __spirv_ocl_rint(x); }
#endif

#endif // __SPIR__ || __SPIRV__ || __NVPTX__ || __AMDGCN__
9 changes: 5 additions & 4 deletions libdevice/cmath_wrapper_fp64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,17 +188,18 @@ double nearbyint(double x) { return __nv_nearbyint(x); }
extern "C" SYCL_EXTERNAL double __nv_rint(double);
DEVICE_EXTERN_C_INLINE
double rint(double x) { return __nv_rint(x); }
#endif // __NVPTX__

#ifdef __AMDGCN__
#elif defined(__AMDGCN__)
extern "C" SYCL_EXTERNAL double __ocml_nearbyint_f64(double);
DEVICE_EXTERN_C_INLINE
double nearbyint(double x) { return __ocml_nearbyint_f64(x); }

extern "C" SYCL_EXTERNAL double __ocml_rint_f64(double);
DEVICE_EXTERN_C_INLINE
double rint(double x) { return __ocml_rint_f64(x); }
#endif // __AMDGCN__
#else
DEVICE_EXTERN_C_INLINE
double rint(double x) { return __spirv_ocl_rint(x); }
#endif

#if defined(_MSC_VER)
#include <math.h>
Expand Down
12 changes: 12 additions & 0 deletions libdevice/test/check_cmath.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
REQUIRES: libsycldevice

Check functions in fp32 libdevice spirv file.

RUN: llvm-spirv --spirv-target-env=SPV-IR -r %libsycldevice_spv_dir/libsycl-cmath.spv -o %t.bc
RUN: llvm-dis %t.bc -o %t.ll
RUN: FileCheck %s --input-file %t.ll

CHECK: target triple ={{.*}}spir64

CHECK-LABEL: define spir_func float @rintf(
CHECK: call spir_func float @_Z16__spirv_ocl_rintf(