-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Fix linking of compressed device images when dependencies are not compressed #18906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jinge90 @steffenlarsen fyi. This is the bug that was causing pytorch test failure in CMPLRLLVM-67948. Turns out #16729 merely exposed it. |
jinge90
approved these changes
Jun 11, 2025
maarquitos14
approved these changes
Jun 11, 2025
CUDA failure is a known flaky bug, tracked in #17285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When linking device images, we reject dependencies whose image format does not match the parent image. However, consider the case when parent image is compressed, while dependencies are not (demonstrated in the test case attached to this PR). In this case, we are incorrectly rejecting device images and thus causing
No device image found for external symbol
error.Solution
If the format of the main and dependent device image differs and one of them is compressed, we decompress them and recheck the format of decompressed device images.
One side-effect of this solution is that now we'll have to decompress device images, even if we are not using them. For example, when format of decompressed main and dependent images differs. Unfortunately, there's no way to find format of the compressed device image, without first decompressing it.
However, I don't think this will incur a significant overhead as (1) we decompress device image only once and cache it for subsequent use, and (2) we decompress only if the dependent device image has an export symbol that main device image wants (when finding which images to link) and if it is compatible with the device.