[SYCL] Change event wait scope flag in Level Zero #1898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jandres742 , please provide more description why this is needed and what side affects it has, if any. |
Set it to ZE_EVENT_SCOPE_FLAG_HOST, so cache hierarchies are flushed in host scope. This ensures that when host is waiting on a event with zeEventHostSynchronize(), that changes in the event state are correctly propagated and seen by the host. Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
jandres742
force-pushed
the
improve_event_scope
branch
from
9014229 to
0272ec9
Compare
jandres742
changed the title
Reworded. |
iclsrc
pushed a commit
that referenced
this pull request
Jun 6, 2024
Some of the upstream PRs are getting backported to the llvm_release_* branches, but those changes are never released. That prevents them from distributing as precompiled packages in various distributions like conda-forge and others. This PR targets this issue by creating automated workflow that is triggered once a month and generates automated releases for each such branch if there were changes since last release. This PR Adds workflow to generate releases every month from llvm_release_* branches in the format %llvm_major%.%llvm_minor%.%latest patch version +1%. For example: v18.1.1 v17.0.2 v17.0.1 v14.0.1 etc Release description matches as close as possible to current releases. The only difference is that llvm versions is represented by two numbers, instead of three, because it is impossible to recover exact version. You can check out example of generated versions here (there are few releases from the original proposal): https://github.com/ZzEeKkAa/SPIRV-LLVM-Translator/releases Workflow is set to be triggered once a month. It is also possible to trigger it manually from github actions UI. Merge process Merge the PR to main Trigger workflow manually Note There is no need to backport changes to all branches, since workflow dispatch on schedule basis can be performed only from main branch. Fixes: #1898 Fixes: #1508 Original commit: KhronosGroup/SPIRV-LLVM-Translator@63e89a9a268e5c2
jsji
pushed a commit
that referenced
this pull request
Jun 27, 2024
Some of the upstream PRs are getting backported to the llvm_release_* branches, but those changes are never released. That prevents them from distributing as precompiled packages in various distributions like conda-forge and others. This PR targets this issue by creating automated workflow that is triggered once a month and generates automated releases for each such branch if there were changes since last release. This PR Adds workflow to generate releases every month from llvm_release_* branches in the format %llvm_major%.%llvm_minor%.%latest patch version +1%. For example: v18.1.1 v17.0.2 v17.0.1 v14.0.1 etc Release description matches as close as possible to current releases. The only difference is that llvm versions is represented by two numbers, instead of three, because it is impossible to recover exact version. You can check out example of generated versions here (there are few releases from the original proposal): https://github.com/ZzEeKkAa/SPIRV-LLVM-Translator/releases Workflow is set to be triggered once a month. It is also possible to trigger it manually from github actions UI. Merge process Merge the PR to main Trigger workflow manually Note There is no need to backport changes to all branches, since workflow dispatch on schedule basis can be performed only from main branch. Fixes: #1898 Fixes: #1508 Original commit: KhronosGroup/SPIRV-LLVM-Translator@63e89a9a268e5c2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set it to ZE_EVENT_SCOPE_FLAG_HOST, so cache hierarchies are
flushed in host scope.
This ensures that when host is waiting on a event with
zeEventHostSynchronize(), that changes in the event state
are correctly propagated and seen by the host.
Signed-off-by: Jaime Arteaga jaime.a.arteaga.molina@intel.com