[SYCL][Unittests] Fix unloading of mock images on Windows #19068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of mock images try to unload the images using __sycl_unregister_lib. However, this is a no-op on Windows under the assumption that shutdown will handle the images. This causes unittests, like RootGroup, to leave dead binaries in the program manager that subsequent test runs may pick up. This commit fixes this issue by having the mock image arrays forciby remove the images from the program manager instead. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Turns out this issue is wider than just the unittests. Converting to draft with the expectation of closing this in favor of a runtime library fix: #19074 |
|
The RootGroup test provoking a failure has been fixed separately, but this change should still make the mock images more robust to future tests wanting to leverage the functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of mock images try to unload the images using __sycl_unregister_lib. However, this is a no-op on Windows under the assumption that shutdown will handle the images. This causes unittests, like RootGroup, to leave dead binaries in the program manager that subsequent test runs may pick up. This commit fixes this issue by having the mock image arrays forciby remove the images from the program manager instead.