[UR][L0] Init/deinit L0 adapter on first/last use #19089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a global constructor to initialize the L0 adapter, do it in the first call to `urAdapterGet`. Likewise, instead of de-initing it as a global destructor, do it in the last call to `urAdapterRelease`. As well as not doing L0 initialization where the user is not using L0, it also allows `urAdapterRelease` to be called in a global destructor (e.g. what the SYCL runtime does) without worrying about global destructor order.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
pbalcer
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a global constructor to initialize the L0 adapter,
do it in the first call to
urAdapterGet. Likewise, instead ofde-initing it as a global destructor, do it in the last call to
urAdapterRelease.As well as not doing L0 initialization where the user is not using
L0, it also allows
urAdapterReleaseto be called in a globaldestructor (e.g. what the SYCL runtime does) without worrying
about global destructor order.