[UR][L0] urDevice when numdevices is not zero #19103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When NumDevices is not zero and when phDevice is null, the user cannot query the number of devices. This addresses that issue. Signed-off-by: Zhang, Winston <winston.zhang@intel.com>
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses an issue where a non-zero NumDevices value and a null phDevice prevent users from querying the number of devices. The change ensures that when the output devices pointer is null or when fewer output entries than available devices are requested, the function returns the correct device count.
- Added an enhanced condition in urDeviceGet to cover the case when Devices is null and fewer entries are provided.
- The condition now checks if (*NumDevices == 0) or if (NumEntries < ZeDeviceCount && !Devices) to set *NumDevices accordingly.
Comments suppressed due to low confidence (1)
unified-runtime/source/adapters/level_zero/device.cpp:170
- [nitpick] Consider adding an inline comment to explain the rationale behind checking (NumEntries < ZeDeviceCount && !Devices) to make the logic clearer for future maintenance.
if (*NumDevices == 0 || (NumEntries < ZeDeviceCount && !Devices))
pbalcer
reviewed
Jun 24, 2025
potential uninitialized as it is an output variable. Signed-off-by: Zhang, Winston <winston.zhang@intel.com>
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Zhang, Winston <winston.zhang@intel.com>
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NumDevices is not zero and when phDevice is null, the user cannot query the number of devices. This addresses that issue.