[SYCL][UR] Unify logging and leak checking for L0 v1 and v2 #19328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
reviewed
Jul 8, 2025
To account for zeDriverGet calls done by the legacy adapter in checkL0LoaderTeardown()
aelovikov-intel
approved these changes
Jul 9, 2025
pbalcer
approved these changes
Jul 10, 2025
|
@intel/sycl-graphs-reviewers could you please take a look? I had to include a fix for kernel leak in command_buffer implementation for v2 |
EwanC
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed so that we can enable V2 adapter by default on certain platforms: #19333
The reason is that we need to load both adapters (legacy and v2) to check the device version. However, loading v2 adapter causes L0 loader to emit logs for all API calls (if ZE_DEBUG=1 is set). Since the legacy adapter used different logic for printing API calls, this would result in printing the same logs twice. This patch fixes that.