Skip to content

[SYCL][NFC] Prepare for -Wconversion [1/N] #19400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from

Conversation

AlexeySachkov
Copy link
Contributor

-Wconversion is required per our SDL processes and it will be enabled in #19306.

Updated all literal arguments passed to UR APIs, because corresponding functions expect an unsigned integer.

`-Wconversion` is required per our SDL processes and it will be enabled
in intel#19306.

Updated all literal arguments passed to UR APIs, because corresponding
functions expect an unsigned integer.
@AlexeySachkov AlexeySachkov marked this pull request as ready for review July 11, 2025 13:09
@AlexeySachkov AlexeySachkov requested review from a team as code owners July 11, 2025 13:09
@AlexeySachkov
Copy link
Contributor Author

I see sporadic failures on Windows, but I don't think that they are anyhow related to the patch: the very first version (before applying clang-format) passed all tests.

What I see now is

Test d:\github\_work\llvm\llvm\build-e2e\workgroupmemory\output\basic_usage.cpp.tmp.out hung!

And on restart:

FAIL: SYCL :: Reduction/reduction_big_data.cpp (740 of 2450)
******************** TEST 'SYCL :: Reduction/reduction_big_data.cpp' FAILED ********************
Exit Code: 3221225477

Command Output (stdout):
--
# RUN: at line 2
env ONEAPI_DEVICE_SELECTOR=level_zero:gpu  D:\github\_work\llvm\llvm\build-e2e\Reduction\Output\reduction_big_data.cpp.tmp.out
# executed command: env ONEAPI_DEVICE_SELECTOR=level_zero:gpu 'D:\github\_work\llvm\llvm\build-e2e\Reduction\Output\reduction_big_data.cpp.tmp.out'
# .---command stdout------------
# | Device: Intel(R) Arc(TM) B580 Graphics, MaxWGSize: 1024, LocalMemSize: 131072, Driver: 1.6.33511
# | Start, T=float, BOp=struct sycl::_V1::maximum<void>, Range={{1049600}, {1024}}. PASSED
# `-----------------------------
# error: command failed with exit status: 0xc0000005

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants