Skip to content

[SYCL] get_access and get_host access enabling #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 25, 2020

Conversation

iburyl
Copy link
Contributor

@iburyl iburyl commented Jun 22, 2020

This second patch finishes the implementation of SYCL_INTEL_accessor_simplification extension.

It adds:

Signed-off-by: iburylov <ilya.burylov@intel.com>
@iburyl iburyl requested a review from a team as a code owner June 22, 2020 14:15
@iburyl iburyl requested a review from sergey-semenov June 22, 2020 14:15
iburylov added 2 commits June 22, 2020 17:36
Signed-off-by: iburylov <ilya.burylov@intel.com>
Signed-off-by: iburylov <ilya.burylov@intel.com>
@iburyl iburyl added the spec extension All issues/PRs related to extensions specifications label Jun 22, 2020
@iburyl
Copy link
Contributor Author

iburyl commented Jun 23, 2020

@bader
Do you agree with such test decomposition?

I made two separate groups of tests, with focus on testing correct deduction for each available constructor:

  • for host accessors
  • for device accessors.

Each of them is independently run for:

  • accessors constructors interfaces and
  • buffer get_[host_]access interface.

Other cases, such as working, when wrapped into classes, or when id is passed to operator[], or when buffer has custom allocator etc. are left to original test, which is no longer focusing on deduction rules.

sergey-semenov
sergey-semenov previously approved these changes Jun 23, 2020
Copy link
Contributor

@sergey-semenov sergey-semenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM except for a minor comment

Signed-off-by: iburylov <ilya.burylov@intel.com>
sergey-semenov
sergey-semenov previously approved these changes Jun 23, 2020
Signed-off-by: iburylov <ilya.burylov@intel.com>
@bader bader merged commit af792cb into intel:sycl Jun 25, 2020
@iburyl iburyl deleted the get_host_access branch June 25, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec extension All issues/PRs related to extensions specifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants