[SYCL][NFC] Move kernel launch property parsing out of `sycl::handler` #19589

uditagarwal97 · 2025-07-24T21:07:14Z

Motivation is to decouple kernel launch property parsing from sycl::handler so that we can reuse this code for no-handler submission path.

…_refactor

Copilot

Pull Request Overview

This PR refactors kernel launch property parsing to move it out of the sycl::handler class into a separate helper structure for better code organization and reusability. The motivation is to enable reuse of kernel launch property parsing code in no-handler submission paths.

Key Changes:

Creates KernelLaunchPropertyWrapper struct to encapsulate property parsing logic
Converts kernel launch properties to use std::optional to track if properties have been set
Updates all references to kernel properties to use the new structure with dereferencing

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
sycl/include/sycl/detail/kernel_launch_helper.hpp	Implements new `KernelLaunchPropertyWrapper` with property parsing methods
sycl/include/sycl/handler.hpp	Updates handler to use new property wrapper and adds helper methods
sycl/source/detail/handler_impl.hpp	Makes handler_impl inherit from `KernelLaunchPropertyWrapper`
sycl/source/handler.cpp	Updates property handling to use new structure and adds property setter method
sycl/unittests/scheduler/*.cpp	Updates mock handlers to dereference optional kernel properties
sycl/test/virtual-functions/properties-negative.cpp	Updates expected error location from handler.hpp to kernel_launch_helper.hpp
sycl/test/extensions/properties/non_esimd_kernel_fp_control.cpp	Updates expected error location
sycl/test/include_deps/sycl_detail_core.hpp.cpp	Adjusts include dependency ordering
sycl/unittests/program_manager/arg_mask/EliminatedArgMask.cpp	Updates mock handler to use dereferenced properties

sycl/include/sycl/detail/kernel_launch_helper.hpp

Copilot · 2025-07-27T01:56:38Z

sycl/include/sycl/detail/kernel_launch_helper.hpp

+      MKernelClusterSize.fill(0);
+    }
+
+    KernelLaunchPropertiesT &operator=(const KernelLaunchPropertiesT &Other) {


The custom assignment operator should have a corresponding custom copy constructor, destructor, and move operations following the Rule of Five, or use the default implementations if possible.

Yeah, why not = default;?

In hindsight, overriding the assignment operator wasn't the best choice as what I instead wanted is to have a method for taking union of two properties. This method is required as on some code paths we parse multiple property sets for the same kernel. So, I've instead added another method takeUnionOfProperties for the same.

sycl/include/sycl/detail/kernel_launch_helper.hpp

Co-authored-by: Andrei Elovikov <andrei.elovikov@intel.com>

…into private/udit/property_refactor

…ant copy of StableKernelCacheConfig

…r:: func

sycl/include/sycl/handler.hpp

aelovikov-intel · 2025-07-30T22:47:51Z

sycl/source/handler.cpp

@@ -2076,10 +2076,12 @@ static bool checkContextSupports(detail::context_impl &ContextImpl,
  return SupportsOp;
 }

+#ifndef __INTEL_PREVIEW_BREAKING_CHANGES


Can we call "new" functions from here as well?

Done in ed746be

sycl/source/handler.cpp

aelovikov-intel · 2025-07-30T22:56:23Z

sycl/source/handler.cpp

+    if (KernelLaunchProperties.MClusterDims == 1) {
+      sycl::range<1> ClusterSizeTrimmed = {
+          KernelLaunchProperties.MClusterSize[0]};
+      impl->MNDRDesc.setClusterDimensions(ClusterSizeTrimmed);


Can't we just use KLProps directly in place of MNDRDes (wherever it's used)? Duplicating the same information in two different data members looks very weird...

IIUC, KLProps and MNDRDes are not interchangeable. The only information common between them is the cluster range and MNDRDes contains other info as well, like local and global size, which KLProps doesn't.

"Doesn't" doesn't mean "shouldn't", does it? Before the patch there was only MNDRDes, after this patch there is at least some duplication of data. That doesn't look good.

Hmm.. looking at the usage of MNDRDes, it's usually set alongside with other kernel launch properties, so it makes sense to also have MNDRDes within KLProps. Let me try that out.

Co-authored-by: Andrei Elovikov <andrei.elovikov@intel.com>

uditagarwal97 · 2025-07-31T16:40:10Z

@aelovikov-intel would like to review the entire no-handler design first before moving ahead with this PR. Closing this PR for the time being then.

uditagarwal97 added 4 commits July 23, 2025 20:00

Seperate out property parsing in a seperate DS

ba2e6c4

[SYCL][NFC] Decouple property parsing from KernelWrapper

a09cbd0

Move property pasring into a seperate DS

364708d

Merge remote-tracking branch 'origin/sycl' into private/udit/property…

8386380

…_refactor

uditagarwal97 self-assigned this Jul 24, 2025

uditagarwal97 had a problem deploying to WindowsCILock July 24, 2025 21:07 — with GitHub Actions Failure

uditagarwal97 had a problem deploying to WindowsCILock July 24, 2025 21:35 — with GitHub Actions Failure

Fix conditional property parsing

bb8875b

uditagarwal97 had a problem deploying to WindowsCILock July 25, 2025 19:06 — with GitHub Actions Failure

uditagarwal97 had a problem deploying to WindowsCILock July 25, 2025 19:31 — with GitHub Actions Failure

uditagarwal97 added 3 commits July 25, 2025 22:33

Fix root_sync property parsing

681258f

Merge remote-tracking branch 'origin/sycl' into private/udit/property…

2089858

…_refactor

Fix sycl_detail_core.hpp.cpp after merge

3c3d3f6

uditagarwal97 had a problem deploying to WindowsCILock July 25, 2025 20:49 — with GitHub Actions Failure

uditagarwal97 temporarily deployed to WindowsCILock July 25, 2025 21:15 — with GitHub Actions Inactive

Beautify code

70137e1

uditagarwal97 had a problem deploying to WindowsCILock July 27, 2025 01:30 — with GitHub Actions Error

Remove TODOs

26660c8

uditagarwal97 marked this pull request as ready for review July 27, 2025 01:49

uditagarwal97 requested a review from a team as a code owner July 27, 2025 01:49

uditagarwal97 requested review from againull and aelovikov-intel July 27, 2025 01:49

uditagarwal97 had a problem deploying to WindowsCILock July 27, 2025 01:50 — with GitHub Actions Failure

uditagarwal97 requested a review from Copilot July 27, 2025 01:55

Copilot AI reviewed Jul 27, 2025

View reviewed changes

uditagarwal97 had a problem deploying to WindowsCILock July 27, 2025 02:18 — with GitHub Actions Failure

Updated Windows ABI symbol dump

60db900

uditagarwal97 had a problem deploying to WindowsCILock July 29, 2025 23:33 — with GitHub Actions Error

Apply suggestions from code review

9e06813

Co-authored-by: Andrei Elovikov <andrei.elovikov@intel.com>

uditagarwal97 had a problem deploying to WindowsCILock July 29, 2025 23:35 — with GitHub Actions Error

uditagarwal97 added 2 commits July 30, 2025 02:00

Simply check for use_root_sync_key property

7ffacc7

Merge remote-tracking branch 'origin/private/udit/property_refactor' …

8e9cfd0

…into private/udit/property_refactor

uditagarwal97 temporarily deployed to WindowsCILock July 30, 2025 00:02 — with GitHub Actions Inactive

uditagarwal97 temporarily deployed to WindowsCILock July 30, 2025 00:31 — with GitHub Actions Inactive

uditagarwal97 requested a review from aelovikov-intel July 30, 2025 14:38

Rename processProperties to processKernelProperties, and remove redud…

8bc0147

…ant copy of StableKernelCacheConfig

uditagarwal97 had a problem deploying to WindowsCILock July 30, 2025 20:18 — with GitHub Actions Failure

uditagarwal97 temporarily deployed to WindowsCILock July 30, 2025 20:43 — with GitHub Actions Inactive

Make handler::processLaunchProperties call KernelLaunchPropertyWrappe…

39ee8ac

…r:: func

uditagarwal97 had a problem deploying to WindowsCILock July 30, 2025 22:33 — with GitHub Actions Error

Update comment on setKernelCacheConfig

07884d6

uditagarwal97 had a problem deploying to WindowsCILock July 30, 2025 22:43 — with GitHub Actions Failure

aelovikov-intel reviewed Jul 30, 2025

View reviewed changes

uditagarwal97 temporarily deployed to WindowsCILock July 30, 2025 23:10 — with GitHub Actions Inactive

Apply suggestions from code review

d39d4bb

Co-authored-by: Andrei Elovikov <andrei.elovikov@intel.com>

uditagarwal97 had a problem deploying to WindowsCILock July 31, 2025 14:31 — with GitHub Actions Error

Delegate verifyDeviceHasProgressGuarantee to new code

ed746be

uditagarwal97 had a problem deploying to WindowsCILock July 31, 2025 14:43 — with GitHub Actions Failure

uditagarwal97 temporarily deployed to WindowsCILock July 31, 2025 16:09 — with GitHub Actions Inactive

uditagarwal97 closed this Jul 31, 2025

bader deleted the private/udit/property_refactor branch August 2, 2025 00:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL][NFC] Move kernel launch property parsing out of `sycl::handler` #19589

[SYCL][NFC] Move kernel launch property parsing out of `sycl::handler` #19589

uditagarwal97 commented Jul 24, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Jul 27, 2025

Uh oh!

aelovikov-intel Jul 28, 2025

Uh oh!

uditagarwal97 Jul 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aelovikov-intel Jul 30, 2025

Uh oh!

uditagarwal97 Jul 31, 2025

Uh oh!

Uh oh!

aelovikov-intel Jul 30, 2025

Uh oh!

uditagarwal97 Jul 31, 2025

Uh oh!

aelovikov-intel Jul 31, 2025

Uh oh!

uditagarwal97 Jul 31, 2025

Uh oh!

uditagarwal97 commented Jul 31, 2025

Uh oh!

Uh oh!

[SYCL][NFC] Move kernel launch property parsing out of sycl::handler #19589

[SYCL][NFC] Move kernel launch property parsing out of sycl::handler #19589

Conversation

uditagarwal97 commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

uditagarwal97 commented Jul 31, 2025

Uh oh!

Uh oh!

[SYCL][NFC] Move kernel launch property parsing out of `sycl::handler` #19589

[SYCL][NFC] Move kernel launch property parsing out of `sycl::handler` #19589

uditagarwal97 commented Jul 24, 2025 •

edited

Loading