[UR][L0] Fix allocation lookup in EnqueuedPool #19638
Open
+159
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswiecicki
approved these changes
Jul 30, 2025
staniewzki
force-pushed
the
enqueued-pool
branch
from
1c623a3 to
8065a18
Compare
pbalcer
approved these changes
Jul 30, 2025
| @@ -43,25 +44,40 @@ class EnqueuedPool { | |||
| bool cleanup(); | |||
| bool cleanupForQueue(void *Queue); | |||
|
|
|||
| private: | |||
| // Allocations are grouped by queue and alignment. | |||
| struct AllocationGroupKey { | |||
There was a problem hiding this comment.
We should be consistent, either use a custom comparator or implement operator< in the key for both types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the allocation management algorithm to address cases where it fails to find suitable allocations due to how it performs lower bound searches.
Example:
If we request
align=64,size=512, the current code looks atAllocation(align=4096, size=128)and skips the rest, even thoughAllocation(align=4096, size=1024)would work.This PR introduces grouping the allocations by queue and alignment.