-
Notifications
You must be signed in to change notification settings - Fork 766
[SYCL] Support standard library functions for AOT compilation #2012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
files (e.g. `libsycl-fallback-cassert.o`). Device code in these object | ||
files is identical to the the `*.spv` files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect the device code in .o files to be llvm IR bitcode, if it is produced with '-fsycl -c'.
Is this really a SPIR-V now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess Andrew meant that the device code in the object files is identical to the device code in the SPV files, but the format is unspecified. It should be LLVM IR bitcode, not SPIR-V, inside the fallback object files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vzakhari is correct. I will reword this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Please check if it is OK now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
files (e.g. `libsycl-fallback-cassert.o`). Device code in these object | ||
files is identical to the the `*.spv` files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess Andrew meant that the device code in the object files is identical to the device code in the SPV files, but the format is unspecified. It should be LLVM IR bitcode, not SPIR-V, inside the fallback object files.
Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for devicelib
Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implement DebugLine/DebugNoLine for NonSemantic.Shader.DebugInfo.100 and NonSemantic.Shader.DebugInfo.200. Updated test/DebugInfo/NonSemantic/Shader200/DebugInfoStringType.ll to test these changes. Original commit: KhronosGroup/SPIRV-LLVM-Translator@3f6d94a
Fallback libraries are now compiled into object files, so they can be
linked at compile time.
Signed-off-by: Andrew Savonichev andrew.savonichev@intel.com