Adding buffer_location SPIR-V spec as an extension #2084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used for heterogenous global memory in FPGA targets
MrSidims
added a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 10, 2020
This extension adds a function parameter decoration that is useful for FPGA targets. This decoration indicates that a particular global memory pointer can only access a articular physical memory location. Knowing this information at compile time can allow FPGA compilers to generate load store units of lower area for accesses done through such a pointer. Specification: intel/llvm#2084 Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
MrSidims
added a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 10, 2020
This extension adds a function parameter decoration that is useful for FPGA targets. This decoration indicates that a particular global memory pointer can only access a articular physical memory location. Knowing this information at compile time can allow FPGA compilers to generate load store units of lower area for accesses done through such a pointer. Specification: intel/llvm#2084 Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
MrSidims
reviewed
Jul 13, 2020
MrSidims
added a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 24, 2020
This extension adds a function parameter decoration that is useful for FPGA targets. This decoration indicates that a particular global memory pointer can only access a articular physical memory location. Knowing this information at compile time can allow FPGA compilers to generate load store units of lower area for accesses done through such a pointer. Specification: intel/llvm#2084 Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
MrSidims
added a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 24, 2020
This extension adds a function parameter decoration that is useful for FPGA targets. This decoration indicates that a particular global memory pointer can only access a particular physical memory location. Knowing this information at compile time can allow FPGA compilers to generate load store units of lower area for accesses done through such a pointer. Specification: intel/llvm#2084 Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
MrSidims
added a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 24, 2020
This extension adds a function parameter decoration that is useful for FPGA targets. This decoration indicates that a particular global memory pointer can only access a particular physical memory location. Knowing this information at compile time can allow FPGA compilers to generate load store units of lower area for accesses done through such a pointer. Specification: intel/llvm#2084 Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
MrSidims
added a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 24, 2020
This extension adds a function parameter decoration that is useful for FPGA targets. This decoration indicates that a particular global memory pointer can only access a particular physical memory location. Knowing this information at compile time can allow FPGA compilers to generate load store units of lower area for accesses done through such a pointer. Specification: intel/llvm#2084 Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
AlexeySotkin
pushed a commit
to KhronosGroup/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 27, 2020
This extension adds a function parameter decoration that is useful for FPGA targets. This decoration indicates that a particular global memory pointer can only access a particular physical memory location. Knowing this information at compile time can allow FPGA compilers to generate load store units of lower area for accesses done through such a pointer. Specification: intel/llvm#2084 Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jul 28, 2020
This extension adds a function parameter decoration that is useful for FPGA targets. This decoration indicates that a particular global memory pointer can only access a particular physical memory location. Knowing this information at compile time can allow FPGA compilers to generate load store units of lower area for accesses done through such a pointer. Specification: intel#2084 Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
|
@intel/dpcpp-specification-reviewers, could you take a look, please? |
1 similar comment
|
@intel/dpcpp-specification-reviewers, could you take a look, please? |
bader
added
the
spec extension
|
@ajaykumarkannan @tiwaria1 @GarveyJoe could some of you re-create this PR? Also can we consider this extension to be finished or other changes are required? |
I will try to re-start upstreaming the buffer_location property. If I cannot get to it by then I will find a different owner. |
jsji
pushed a commit
that referenced
this pull request
Jul 17, 2023
This fixes most of the tests to use -emit-opaque-pointers. There are a few tests not yet converted for various reasons: Several tests only have check lines for opaque struct declarations. These are not emitted in opaque pointer mode, so the tests need deeper rewrites. A few tests check both typed and opaque pointer output. A few tests only make sense with typed pointer output (ForwardPtr.ll and RecursiveType.ll in particular). One test has a crash in reverse translation. Outside of these cases, all tests should now be using opaque pointer for testing reverse translation. Original commit: KhronosGroup/SPIRV-LLVM-Translator@0dc80be
Chenyang-L
added a commit
that referenced
this pull request
Jul 31, 2023
This reverts commit 6a57011.
jsji
pushed a commit
that referenced
this pull request
Aug 11, 2023
This fixes most of the tests to use -emit-opaque-pointers. There are a few tests not yet converted for various reasons: Several tests only have check lines for opaque struct declarations. These are not emitted in opaque pointer mode, so the tests need deeper rewrites. A few tests check both typed and opaque pointer output. A few tests only make sense with typed pointer output (ForwardPtr.ll and RecursiveType.ll in particular). One test has a crash in reverse translation. Outside of these cases, all tests should now be using opaque pointer for testing reverse translation. Original commit: KhronosGroup/SPIRV-LLVM-Translator@0dc80be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used for heterogenous global memory in FPGA targets