Skip to content

[UR] check for dlsym errors and valid pfnGet #20869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bratpiorka wants to merge 2 commits into
base: sycl
Choose a base branch
from
Open

[UR] check for dlsym errors and valid pfnGet #20869

bratpiorka wants to merge 2 commits into from
+46 −3

Conversation

@bratpiorka
Copy link
Contributor

@bratpiorka bratpiorka commented Dec 10, 2025

two small fixes for Coverity / ASAN:

  • check for dlerror after dlsym
  • check for platform.dditable.Adapter.pfnGet before call

@bratpiorka bratpiorka requested a review from a team as a code owner December 10, 2025 10:05
@KFilipek
Copy link
Contributor

KFilipek commented Dec 10, 2025

Here is a simple explanation about YAML and Mako: https://oneapi-src.github.io/unified-runtime/core/CONTRIB.html#generating-source

@bratpiorka
Copy link
Contributor Author

bratpiorka commented Dec 11, 2025

@intel/unified-runtime-reviewers please review.

The CI fails on the BMG end-to-end test Basic/parallel_for_range_roundup.cpp
and the RHEL pre-commit configuration step with the following error:

[2025-12-10T15:34:25.325Z]   Target "IPCTests_Preview_Tests" requires the language dialect "CXX20" .
[2025-12-10T15:34:25.325Z]   But the current compiler "GNU" does not support this, or CMake does not
[2025-12-10T15:34:25.325Z]   know the flags to enable it.

these issues are not related to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cperkinsintel cperkinsintel cperkinsintel approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bratpiorka @KFilipek @cperkinsintel