[SYCL][NFC] Make lit tests agnostic to compiler optimizations #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of today SYCL device compiler do not apply any LLVM transformations to emitted LLVM code, but SYCL tests shouldn't rely on this behavior, so this patch explicitly set compiler option to disable any LLVM passes.
These are failing if optimizations are enabled. |
|
@intel/llvm-reviewers-runtime, ping. |
I see. May be not for this PR but we can open an issue and investigate others. |
rbegam
approved these changes
Jul 16, 2020
jsji
pushed a commit
that referenced
this pull request
Aug 11, 2023
getNonOpaquePointerElementType is deprecated. This patch removes 3 calls to it where it's no longer require functional changes. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@3b9f9a6
jsji
pushed a commit
that referenced
this pull request
Aug 11, 2023
'bool llvm::Type::isOpaquePointerTy() const' has been removed. We need to use isPointerTy() instead. This PR handles all uses except one (lib/SPIRV/SPIRVWriter.cpp:279) which is handled in a different PR (#2089) Thanks Original commit: KhronosGroup/SPIRV-LLVM-Translator@c7a0b9b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of today SYCL device compiler do not apply any LLVM transformations
to emitted LLVM code, but SYCL tests shouldn't rely on this behavior, so
this patch explicitly set compiler option to disable any LLVM passes.