Skip to content

[UR][L0v2] Fix coverity issues #21231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kswiecicki merged 2 commits into from
Feb 12, 2026
Merged

[UR][L0v2] Fix coverity issues #21231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3597df8
[UR][L0v2] Fix coverity issues
kswiecicki Feb 6, 2026
16f41e9
Generalize exception catch
kswiecicki Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions unified-runtime/source/adapters/level_zero/v2/memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ void ur_integrated_buffer_handle_t::copyBackToHostIfNeeded() {
if (result2 == UR_RESULT_SUCCESS) {
writeBackPtr = nullptr;
} else {
UR_LOG(ERR, "Failed to copy-back buffer data: {}", result2);
UR_LOG_SAFE(ERR, "Failed to copy-back buffer data: {}", result2);
}
}
}
Expand Down Expand Up @@ -326,8 +326,11 @@ ur_discrete_buffer_handle_t::~ur_discrete_buffer_handle_t() {
return;

auto srcPtr = getActiveDeviceAlloc();
synchronousZeCopy(hContext, activeAllocationDevice, writeBackPtr, srcPtr,
getSize());
auto ret = synchronousZeCopy(hContext, activeAllocationDevice, writeBackPtr,
srcPtr, getSize());
if (ret != UR_RESULT_SUCCESS) {
UR_LOG_SAFE(ERR, "Failed to copy-back buffer data: {}", ret);
}
}

void *ur_discrete_buffer_handle_t::getActiveDeviceAlloc(size_t offset) {
Expand Down
12 changes: 12 additions & 0 deletions unified-runtime/source/common/logger/ur_logger.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,18 @@ inline void init(const std::string &name) { get_logger(name.c_str()); }
URLOG_L_(::logger::get_logger(), level, legacy_message, __VA_ARGS__)
#define UR_LOG_L(logger, level, ...) URLOG_(logger, level, __VA_ARGS__)

// safe version of UR_LOG that catches exceptions from the logger
#define UR_LOG_SAFE(level, ...) \
{ \
try { \
UR_LOG(level, __VA_ARGS__); \
} catch (const std::exception &e) { \
std::fprintf(stderr, "Error during logging: %s\n", e.what()); \
} catch (...) { \
std::fprintf(stderr, "Unknown error during logging\n"); \
} \
}

inline void setLevel(ur_logger_level_t level) { get_logger().setLevel(level); }

inline void setFlushLevel(ur_logger_level_t level) {
Expand Down
Loading