[Driver][NFC] Check pointer Arg before dereferencing.#21287
Open
srividya-sundaram wants to merge 3 commits intointel:syclfrom
Open
[Driver][NFC] Check pointer Arg before dereferencing.#21287srividya-sundaram wants to merge 3 commits intointel:syclfrom
srividya-sundaram wants to merge 3 commits intointel:syclfrom
Conversation
srividya-sundaram
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
srividya-sundaram
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
reviewed
Feb 13, 2026
| Arg *SYCLSplitMode = | ||
| Args.getLastArg(options::OPT_fsycl_device_code_split_EQ); | ||
| Arg *OffloadLTO = Args.getLastArg(options::OPT_foffload_lto, | ||
| options::OPT_foffload_lto_EQ); |
Contributor
There was a problem hiding this comment.
This looks like something that would benefit the community as it isn't specific to SYCL. Would this be better to just upstream instead of doing intel/llvm?
Contributor
Author
There was a problem hiding this comment.
There are to SYCL specific checks here before some of these diagnostics are emitted (like SYCLSplitMode). Unless I am mis-understanding what you are referring to.
Contributor
There was a problem hiding this comment.
Yes, there are SYCL specific things here, but the fix itself can be applied to upstream and be pulled into intel/llvm as it also impacts OpenMP upstream behaviors.
srividya-sundaram
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
srividya-sundaram
requested a deployment
to
WindowsCILock
GitHub Actions
In progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #21282