[SYCL][E2E] Add RUN-IF lit keyword#21288
Merged
sarnex merged 1 commit intointel:syclfrom Feb 18, 2026
Merged
Conversation
sarnex
commented
Feb 13, 2026
| // RUN: %if any-device-is-cpu && opencl-aot %{ %{run-aux} %clangxx -fsycl -fsycl-targets=spir64_x86_64 -o %t.x86.out %s %} | ||
| // RUN: %if cpu && opencl-aot %{ %{run} %t.x86.out %} | ||
| // RUN-IF: any-device-is-cpu && opencl-aot, %{run-aux} %clangxx -fsycl -fsycl-targets=spir64_x86_64 -o %t.x86.out %s | ||
| // RUN-IF: cpu, %{run} %t.x86.out |
Contributor
Author
There was a problem hiding this comment.
I removed opencl-aot from the conditional in all the run lines, it's not related to this feature, opencl-aot is a build only feature so it's always false in run mode, so even today this condition never runs
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
Also ignoring the code format CI fail because it's wrong. |
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
approved these changes
Feb 18, 2026
Contributor
uditagarwal97
left a comment
uditagarwal97
left a comment
There was a problem hiding this comment.
Seems like a good idea to me.
Contributor
Author
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new LIT keyword,
RUN-IF, to simplify conditional commands in LIT tests.This is useful for when you have a single test but need to do different things depending on the environment.
You can arleady to this today, but the syntax is verbose, something like
RUN: %if condition %{ case %} %else %{ another_case %}We are planning to use the immediately in interop tests.
I modified some exists tests using the verbose syntax to lock down this new syntax.