[SYCL] Fix not found kernel due to empty kernel name when using set_arg(s) #2181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rg(s) Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
alexbatashev
previously approved these changes
Jul 27, 2020
|
@alexanderfle, please, add a regression test. |
|
@bader, we already have a regression test for that case, one conformance test that checks handler API. |
Interesting... I don't see this test failures in pre-commit or post-commit tests. I think having a small test covering this case in CI will be useful. |
Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
|
@alexbatashev, I have addressed your comments, please review again. |
alexbatashev
approved these changes
Jul 29, 2020
|
@bader, ping |
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jul 30, 2020
…rogram * upstream/sycl: (609 commits) [SYCL] Fix fail in the post commit testing (intel#2210) [SYCL] Materialize shadow local variables for byval arguments before use (intel#2200) [SYCL] Support lambda functions passed to reduction (intel#2190) [SYCL][USM] Improve USM Allocator. (intel#2026) [SYCL] Disallow mutable lambdas (intel#1785) [SYCL][ESIMD] Setup compilation pipeline for ESIMD (intel#2134) [SYCL] Fix not found kernel due to empty kernel name when using set_arg(s) (intel#2181) [SYCL] Fixed check for set_arg (intel#2203) Refactor indirect access calls to minimize invocations. (intel#2185) [SYCL][NFC] Fix potential null-pointer access (intel#2197) [SYCL] Propagate attributes from transitive calls to kernel (intel#1878) [SYCL] Fix warnings from static analysis tool (intel#2193) [SYCL][NFC] Fix ac_float test for compilation with FE optimizations (intel#2184) [GitHub Actions] Uplift clang-format version to 10 (intel#2194) [SYCL][ESIMD] Pass to replace simd* parameters with native llvm vectors. (intel#2097) [SYCL][NFC] Fixed SYCL_PI_TRACE output while selecting a device. (intel#2192) [SYCL][FPGA] New spec for controlling load-store units in FPGAs (intel#2158) [SYCL][Doc] Clarify reqd_sub_group_size (intel#2103) [SYCL] Remove noreturn function attribute (intel#2165) [SYCL] Aligned set_arg behaviour with SYCL specification (intel#2159) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using set_arg(s) function in your code with the cacheable kernel leads to the runtime throws an exception "No kernel named was found -46 (CL_INVALID_KERNEL_NAME)" when the kernel is in process of submitting because the kernel cannot be found in the cache. This patch fixes the issue.
Signed-off-by: Alexander Flegontov alexander.flegontov@intel.com